chore(samples-android): Add optional SAGP build mode#5538
Open
0xadam-brown wants to merge 1 commit into
Open
Conversation
📲 Install BuildsAndroid
|
Adds an optional useSagp flag to Android sample app builds that, when true, applies the Sentry Android Gradle Plugin. (Defaults to false, which matches existing build behavior.) ``` ./gradlew :sentry-samples:sentry-samples-android:installDebug -PuseSagp=true ``` See the Android sample app README for more details.
0xadam-brown
force-pushed
the
chore/use-sagp-with-sample-android-app
branch
from
4a66736 to
2994300
Compare
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds an optional
useSagpflag to Android sample app builds that, when true, applies the Sentry Android Gradle Plugin.Defaults to false, which matches existing build behavior. (Flag omitted == false)
See the new README for more details.
💡 Motivation and Context
Lets us verify SAGP functionality against our Android sample app demos (e.g., auto-instrumentation of SQLite queries, etc.).
💚 How did you test it?
Manually.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps