perf(core): [SDK Overhead reduction for JVM 2] Short-circuit combined scope breadcrumbs#5541
Draft
adinauer wants to merge 1 commit into
Draft
perf(core): [SDK Overhead reduction for JVM 2] Short-circuit combined scope breadcrumbs#5541adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Avoid allocating and sorting a merged breadcrumb queue when only one component scope has breadcrumbs. This keeps the full merge path for multi-scope breadcrumbs and returns the default write scope queue when all scopes are empty. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
romtsn
reviewed
Jun 12, 2026
| final boolean hasIsolationBreadcrumbs = !isolationBreadcrumbs.isEmpty(); | ||
| final boolean hasCurrentBreadcrumbs = !currentBreadcrumbs.isEmpty(); | ||
|
|
||
| if (!hasGlobalBreadcrumbs && !hasIsolationBreadcrumbs && !hasCurrentBreadcrumbs) { |
Member
There was a problem hiding this comment.
hm, but previously we'd been always returning a copy, whereas now it's not a copy anymore, so it could've been modified?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead reduction for JVM)
📜 Description
Short-circuit
CombinedScopeView.getBreadcrumbs()when only one component scope contains breadcrumbs.The method now returns the single non-empty scope queue directly, keeps the existing merged/sorted bounded queue path when multiple scopes have breadcrumbs, and uses the configured default write scope when all queues are empty.
💡 Motivation and Context
This implements the breadcrumb portion of AR-08 from the SDK overhead reduction research. The previous code always allocated a temporary list, copied breadcrumbs from all three scopes, sorted them, allocated a bounded queue, and copied them again, even when only one scope had breadcrumbs.
Avoiding that merge path reduces per-event allocation overhead on the common single-scope breadcrumb path.
💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.CombinedScopeViewTest./gradlew spotlessApply apiDump :sentry:test --tests io.sentry.CombinedScopeViewTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog