fix(nextjs): re-declare captureRouterTransitionStart in index.types#21452
Open
tsushanth wants to merge 1 commit into
Open
fix(nextjs): re-declare captureRouterTransitionStart in index.types#21452tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
Fixes getsentry#19939. `captureRouterTransitionStart` is exported from `./client` but resolves to the client SDK only — without an explicit redeclaration in `index.types`, static analysis tools (oxlint, eslint-plugin-import) that follow the `types` export condition can't find it in the `@sentry/nextjs` namespace, even though the function is available at runtime in browser bundles. This is the same shape used for other client-only exports a few lines above (`linkedErrorsIntegration`, `contextLinesIntegration`, `spanStreamingIntegration`, `withStreamedSpan`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tsushanth
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19939.
Summary
captureRouterTransitionStartis exported from./client/index.tsand resolves correctly at runtime through thebrowserexport condition (index.client.js). It's missing from thetypescondition entry point (index.types.d.ts), so static analysis tools that follow thetypescondition —oxlint,eslint-plugin-import'simport/namespacerule, andtscfrom a server-condition context — report"captureRouterTransitionStart" not found in imported namespace "@sentry/nextjs". The function still works at runtime; only the static-analysis surface is wrong.Root cause
packages/nextjs/src/index.types.tscarries explicitexport declare const X: typeof clientSdk.Xredeclarations for every other client-only export that needs to be visible to the types condition (linkedErrorsIntegration,contextLinesIntegration,spanStreamingIntegration,withStreamedSpan,growthbookIntegration,launchDarklyIntegration, etc.).captureRouterTransitionStartwas added to./client/index.tsbut not mirrored intoindex.types.ts, so it disappears from the published.d.tseven though it's part of the runtime client surface.Fix
Add the missing redeclaration alongside the other client-only exports:
Trivially correct — same shape used for the surrounding declarations.
Note
I wasn't able to run
yarn install/yarn build:devlocally to validate (disk space exhausted on my machine). CI should cover the build, types, and lint checks; happy to rebase or amend if anything surfaces.