Skip to content

feat(react-router): Rename client navigation roots from the route pattern#21463

Merged
chargome merged 1 commit into
developfrom
cg/client-root-pattern-naming
Jun 11, 2026
Merged

feat(react-router): Rename client navigation roots from the route pattern#21463
chargome merged 1 commit into
developfrom
cg/client-root-pattern-naming

Conversation

@chargome

Copy link
Copy Markdown
Member

Parameterizes client navigation root spans from the native route hooks' pattern (e.g. /users/:id) instead of the router.state heuristic, mirroring the server side. Looks like we need to keep the heuristic in place for pageloads though.

closes #21394

@chargome chargome self-assigned this Jun 11, 2026
@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit e6660ff. Configure here.

@chargome chargome marked this pull request as ready for review June 11, 2026 08:21
@chargome chargome requested a review from a team as a code owner June 11, 2026 08:21
@chargome chargome requested review from nicohrubec and s1gr1d and removed request for a team June 11, 2026 08:21
@chargome chargome merged commit f7c54ce into develop Jun 11, 2026
49 checks passed
@chargome chargome deleted the cg/client-root-pattern-naming branch June 11, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name client pageload/navigation roots from the route pattern

2 participants