fix(deps): runtime dependency security fixes - #23245
Open
javascript-sdk-gitflow[bot] wants to merge 1 commit into
Open
fix(deps): runtime dependency security fixes#23245javascript-sdk-gitflow[bot] wants to merge 1 commit into
javascript-sdk-gitflow[bot] wants to merge 1 commit into
Conversation
Resolves GHSA-3jxr-9vmj-r5cp / CVE-2026-13149 (high). Dependabot alert: https://github.com/getsentry/sentry-javascript/security/dependabot/2060 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+7507
to
+7510
| "@sentry/conventions@^0.16.0": | ||
| version "0.16.0" | ||
| resolved "https://registry.yarnpkg.com/@sentry/conventions/-/conventions-0.16.0.tgz#3b58d15714cf44dca1518496c00749eec5525009" | ||
| integrity sha512-fO9PLmHdVURcSPUpWCItWAtgKiMwGdJHbovoSEyLplX5sxs2ugvI4CBPTrkkgqhObnZOD0CnWBKDzSVQYBKEyQ== |
Contributor
There was a problem hiding this comment.
Bug: The PR locks @sentry/conventions to 0.16.0 for @sentry/effect, but it's unverified if this version exports the constants the package imports, risking a runtime error.
Severity: HIGH
Suggested Fix
Verify that @sentry/conventions@0.16.0 exports all constants required by @sentry/effect. If it does not, update the dependency for @sentry/effect in its package.json to use a compatible version of @sentry/conventions (e.g., ^0.19.0 to match other packages) and regenerate the lockfile.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: yarn.lock#L7507-L7510
Potential issue: The pull request introduces a `yarn.lock` entry for
`@sentry/conventions@^0.16.0`, resolving to version `0.16.0`. This dependency is used by
the `@sentry/effect` package, which imports constants like `SENTRY_OP` and
`WEB_SERVER_HTTP_CLIENT_SPAN_OP`. It is unverified if version `0.16.0` of
`@sentry/conventions` actually exports these constants, as other packages in the
repository use version `^0.19.0`. If these exports are missing, it will cause a runtime
failure in the `@sentry/effect` package when tracing is initialized. This change was
part of an automated, unmentioned "dedupe pass", increasing the risk of it being an
unintended breaking change.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batched runtime dependency security fixes. One commit per vulnerability.
Fixes
brace-expansion1.1.11 → 1.1.18 — GHSA-3jxr-9vmj-r5cp / CVE-2026-13149 (high) — https://github.com/getsentry/sentry-javascript/security/dependabot/2060Only
yarn.lockchanged: every vulnerablebrace-expansion@1.1.11instance is a deep transitive dependency pulled in throughminimatch@3in dev/build tooling, all resolving from the^1.1.7range. Bumping the lockfile moves that range to the patched maintenance release1.1.18(> 1.1.16) without anypackage.jsonorresolutionschange. The2.xand5.xlines were also refreshed by the dedupe pass; neither was in the vulnerable range.🤖 Generated with Claude Code