feat(core)!: Remove endTimestamp from SentrySpanArguments - #23269
Open
msonnb wants to merge 1 commit into
Open
Conversation
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 51fda21. Configure here.
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
August 11, 2026 09:36
msonnb
requested review from
a team,
Lms24 and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
August 11, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
endTimestampproperty fromSentrySpanArgumentsand related dead code inSentrySpanand_startChildSpan.Why
StartSpanOptionsnever declaredendTimestamp, butparseSentrySpanArgumentsspreads the user's options, so users could ignore TS and have the span to end immediately by adding theendTimestampproperty.Closes #21405