Skip to content

feat(core)!: Remove endTimestamp from SentrySpanArguments - #23269

Open
msonnb wants to merge 1 commit into
developfrom
ms/remove-end-timestamp
Open

feat(core)!: Remove endTimestamp from SentrySpanArguments#23269
msonnb wants to merge 1 commit into
developfrom
ms/remove-end-timestamp

Conversation

@msonnb

@msonnb msonnb commented Aug 11, 2026

Copy link
Copy Markdown
Member

What

Removes the endTimestamp property from SentrySpanArguments and related dead code in SentrySpan and _startChildSpan.

Why

StartSpanOptions never declared endTimestamp, but parseSentrySpanArguments spreads the user's options, so users could ignore TS and have the span to end immediately by adding the endTimestamp property.

Closes #21405

@msonnb

msonnb commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 51fda21. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.26 kB -0.28% -82 B 🔽
@sentry/browser - with treeshaking flags 28.44 kB -0.38% -108 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.78 kB -0.33% -86 B 🔽
@sentry/browser (incl. Tracing) 48.47 kB +1.39% +662 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.48 kB +1.38% +659 B 🔺
@sentry/browser (incl. Tracing, Profiling) 51.36 kB -2.27% -1.19 kB 🔽
@sentry/browser (incl. Tracing, Replay) 87.89 kB +0.81% +705 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.27 kB +0.86% +653 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 92.6 kB +0.76% +693 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 105.28 kB +0.7% +722 B 🔺
@sentry/browser (incl. Feedback) 47.58 kB -0.22% -101 B 🔽
@sentry/browser (incl. sendFeedback) 35.08 kB -0.26% -90 B 🔽
@sentry/browser (incl. FeedbackAsync) 40.23 kB -0.27% -108 B 🔽
@sentry/browser (incl. Metrics) 31.29 kB -0.38% -117 B 🔽
@sentry/browser (incl. Logs) 31.55 kB -0.34% -105 B 🔽
@sentry/browser (incl. Metrics & Logs) 32.24 kB -0.27% -85 B 🔽
@sentry/react 32.06 kB -0.27% -86 B 🔽
@sentry/react (incl. Tracing) 50.65 kB +1.18% +588 B 🔺
@sentry/vue 35.28 kB -0.49% -171 B 🔽
@sentry/vue (incl. Tracing) 50.41 kB +1.19% +591 B 🔺
@sentry/svelte 30.28 kB -0.29% -86 B 🔽
CDN Bundle 31.52 kB -2.54% -819 B 🔽
CDN Bundle (incl. Tracing) 48.74 kB +1.27% +607 B 🔺
CDN Bundle (incl. Logs, Metrics) 33.75 kB -0.39% -132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 50.72 kB +2.56% +1.26 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.3 kB +1.47% +1.07 kB 🔺
CDN Bundle (incl. Tracing, Replay) 86.34 kB +0.71% +607 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.25 kB +1.42% +1.24 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.04 kB +0.53% +484 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.06 kB +1.3% +1.2 kB 🔺
CDN Bundle - uncompressed 93.59 kB -2.39% -2.28 kB 🔽
CDN Bundle (incl. Tracing) - uncompressed 146.36 kB +1.94% +2.78 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.06 kB -0.45% -444 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.22 kB +3.16% +4.65 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 228.98 kB +1.69% +3.79 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.61 kB +1.06% +2.77 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.45 kB +1.75% +4.65 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.31 kB +1% +2.76 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.14 kB +1.66% +4.64 kB 🔺
@sentry/nextjs (client) 53.21 kB +1.12% +589 B 🔺
@sentry/sveltekit (client) 48.88 kB +1.28% +613 B 🔺
@sentry/core/server 65.42 kB -0.55% -358 B 🔽
@sentry/core/browser 51.74 kB -0.5% -259 B 🔽
@sentry/node 117.85 kB -1.33% -1.58 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.01 kB -1.69% -1.41 kB 🔽
@sentry/aws-serverless 91.38 kB -1.48% -1.36 kB 🔽
@sentry/cloudflare (withSentry) - minified 213.89 kB -0.47% -996 B 🔽
@sentry/cloudflare (withSentry) 528.61 kB -0.41% -2.16 kB 🔽

View base workflow run

@msonnb
msonnb marked this pull request as ready for review August 11, 2026 09:36
@msonnb
msonnb requested review from a team, Lms24 and stephanie-anderson and removed request for a team and stephanie-anderson August 11, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up SentrySpanArguments interface and related dead code in SentrySpan

1 participant