fix(core): Read external propagation context from the carrier - #23271
Merged
Conversation
`otlpIntegration` registered its trace context provider in module state, so it was silently ignored whenever a bundler emitted more than one copy of `@sentry/core` (one per Next.js server chunk, for instance). Errors then fell back to a Sentry-generated trace instead of the active OpenTelemetry one. Adds a `nextjs-otlp` e2e app covering the setup this broke in: OpenTelemetry owns tracing and metrics, Sentry captures errors only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fc257da. Configure here.
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
August 11, 2026 11:27
andreiborza
commented
Aug 11, 2026
Comment on lines
+4
to
+16
| const nextConfig: NextConfig = { | ||
| // The instrumentation hook and the route handlers must share one copy of each OpenTelemetry | ||
| // package, otherwise the providers registered at startup are invisible to the request path. | ||
| serverExternalPackages: [ | ||
| '@opentelemetry/api', | ||
| '@opentelemetry/exporter-metrics-otlp-http', | ||
| '@opentelemetry/exporter-trace-otlp-http', | ||
| '@opentelemetry/resources', | ||
| '@opentelemetry/sdk-metrics', | ||
| '@opentelemetry/sdk-trace-base', | ||
| '@opentelemetry/sdk-trace-node', | ||
| ], | ||
| }; |
Member
Author
There was a problem hiding this comment.
@chargome can you validate if this is needed? Does this make sense?
chargome
reviewed
Aug 11, 2026
Member
There was a problem hiding this comment.
h: The test should cover both Turbopack and webpack (as a variant) - you can check out the other nextjs 16 tests for the setup
Comment on lines
+8
to
+14
| '@opentelemetry/api', | ||
| '@opentelemetry/exporter-metrics-otlp-http', | ||
| '@opentelemetry/exporter-trace-otlp-http', | ||
| '@opentelemetry/resources', | ||
| '@opentelemetry/sdk-metrics', | ||
| '@opentelemetry/sdk-trace-base', | ||
| '@opentelemetry/sdk-trace-node', |
Member
There was a problem hiding this comment.
These will basically just receive a require(<packageName>) in the bundled output. So at runtime this looks up node_modules for this package and just use the version declared in package.json.
If you have different versions of this package floating around (through different dependencies) then this is just undefined behaviour at runtime
Member
There was a problem hiding this comment.
I don't know if that plays a role in our setup since we also ship '@opentelemetry/api' via the sdk
Member
Author
There was a problem hiding this comment.
Probably only plays a role if user's @opentelemetry/api differs from what we use in the SDK I guess. I'll take it out for now.
mydea
approved these changes
Aug 11, 2026
nicohrubec
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
otlpIntegrationkept its trace context provider in module state, so it was silently ignored whenever a bundler emitted more than one copy of@sentry/core, and errors fell back to a Sentry-generated trace instead of the active OpenTelemetry one.Also adds a
nextjs-otlpe2e app covering that setup, where OpenTelemetry owns tracing and metrics and Sentry captures errors only.Why
Next.js splits
@sentry/coreacross server chunks, which made trace connection between OpenTelemetry telemetry and Sentry errors fail in exactly the setup the integration exists for.