Skip to content

test: Remove unneeded orchestrion test apps - #23349

Open
mydea wants to merge 2 commits into
developfrom
fn/remove-e2e-apps
Open

test: Remove unneeded orchestrion test apps#23349
mydea wants to merge 2 commits into
developfrom
fn/remove-e2e-apps

Conversation

@mydea

@mydea mydea commented Aug 12, 2026

Copy link
Copy Markdown
Member

Removing e2e test apps that are orchestrion variants, as this should now be covered generally.

Remaining test apps with orchestrion in the name to verify for followup:

  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 30.31 kB -0.08% -23 B 🔽
@sentry/browser - with treeshaking flags 28.49 kB -0.09% -24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.83 kB -0.1% -25 B 🔽
@sentry/browser (incl. Tracing) 48.56 kB -0.04% -15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 48.57 kB -0.03% -14 B 🔽
@sentry/browser (incl. Tracing, Profiling) 51.44 kB -0.04% -17 B 🔽
@sentry/browser (incl. Tracing, Replay) 87.96 kB -0.04% -29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.33 kB -0.04% -25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 92.68 kB -0.03% -20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 105.36 kB -0.03% -25 B 🔽
@sentry/browser (incl. Feedback) 47.64 kB -0.04% -18 B 🔽
@sentry/browser (incl. sendFeedback) 35.14 kB -0.07% -22 B 🔽
@sentry/browser (incl. FeedbackAsync) 40.29 kB -0.06% -21 B 🔽
@sentry/browser (incl. Metrics) 31.29 kB -0.07% -21 B 🔽
@sentry/browser (incl. Logs) 31.53 kB -0.14% -44 B 🔽
@sentry/browser (incl. Metrics & Logs) 32.2 kB -0.17% -53 B 🔽
@sentry/react 32.11 kB -0.09% -27 B 🔽
@sentry/react (incl. Tracing) 50.75 kB -0.07% -34 B 🔽
@sentry/vue 35.33 kB -0.1% -33 B 🔽
@sentry/vue (incl. Tracing) 50.51 kB -0.04% -19 B 🔽
@sentry/svelte 30.34 kB -0.08% -24 B 🔽
CDN Bundle 31.62 kB -0.07% -21 B 🔽
CDN Bundle (incl. Tracing) 48.88 kB -0.04% -18 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.82 kB -0.13% -42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 50.81 kB -0.1% -48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 74.32 kB -0.08% -53 B 🔽
CDN Bundle (incl. Tracing, Replay) 86.47 kB -0.03% -21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.31 kB -0.06% -47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 92.18 kB -0.03% -21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.13 kB -0.05% -47 B 🔽
CDN Bundle - uncompressed 93.87 kB -0.08% -66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 146.75 kB -0.05% -68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.21 kB -0.14% -132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.47 kB -0.09% -134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.14 kB -0.06% -134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.01 kB -0.03% -68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.72 kB -0.05% -134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.7 kB -0.03% -68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.41 kB -0.05% -134 B 🔽
@sentry/nextjs (client) 53.27 kB -0.06% -27 B 🔽
@sentry/sveltekit (client) 48.97 kB -0.04% -19 B 🔽
@sentry/core/server 65.39 kB -0.11% -70 B 🔽
@sentry/core/browser 51.73 kB -0.16% -78 B 🔽
@sentry/node 117.95 kB -0.03% -29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.07 kB -0.04% -29 B 🔽
@sentry/aws-serverless 91.48 kB -0.04% -31 B 🔽
@sentry/cloudflare (withSentry) - minified 214.04 kB -0.04% -80 B 🔽
@sentry/cloudflare (withSentry) 528.91 kB -0.03% -119 B 🔽

View base workflow run

@mydea
mydea marked this pull request as ready for review August 12, 2026 12:55

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is

@mydea

mydea commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is

hmm maybe we should merge them then I guess?

@chargome

Copy link
Copy Markdown
Member

Yes, I'd merge them 👍

Comment thread dev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs Dismissed
Comment thread dev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts Dismissed
@mydea

mydea commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Yes, I'd merge them 👍

I folded them back into the existing tests!

@chargome chargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants