feat(sync): add read-write lock primitive by jpnurmi · Pull Request #1877 · getsentry/sentry-native

jpnurmi · 2026-07-16T13:02:32Z

Add sentry_rwlock_t, backed by platform-native RW locks. Will be used for scope data in #2042.

#skip-changelog (internal)

codecov · 2026-07-16T13:25:30Z

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.31%. Comparing base (98631e6) to head (8e38214).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
+ Coverage   74.29%   74.31%   +0.02%     
==========================================
  Files         103      103              
  Lines       26811    26817       +6     
  Branches     4887     4881       -6     
==========================================
+ Hits        19918    19928      +10     
- Misses       5554     5555       +1     
+ Partials     1339     1334       -5

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-09-09T11:38:46Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8e38214

Add `sentry_rwlock_t` backed by platform native RW locks.

limbonaut · 2026-09-09T14:35:44Z

+#        define sentry__rwlock_read_lock(Lock) AcquireSRWLockShared(Lock)
+#        define sentry__rwlock_read_unlock(Lock) ReleaseSRWLockShared(Lock)
+#        define sentry__rwlock_write_lock(Lock) AcquireSRWLockExclusive(Lock)
+#        define sentry__rwlock_write_unlock(Lock) ReleaseSRWLockExclusive(Lock)


Will sentry_rwlock_t be potentially used recursively? It shouldn't because MS documents it as "should not be acquired recursively". Recursive access (same thread) can deadlock. We should acknowledge that in a comment at least.

This won't be used recursively, no. We will no longer lock across function calls that might need the same lock recursively, but only for the duration of reading or writing a piece of (scope) data.

How's this description?

A non-recursive read-write lock for short critical sections around protected variable access. Allows multiple concurrent readers, or a single exclusive writer.

Based on SRWLOCK on Windows, and pthread_rwlock_t on POSIX.

Great description 👍

jpnurmi changed the title ~~perf: use recursive rwlock for global scope~~ [WIP] perf: use recursive rwlock for global scope Jul 16, 2026

cursor Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread src/sentry_sync.h Outdated

Comment thread src/sentry_sync.h Outdated

cursor Bot reviewed Jul 16, 2026

View reviewed changes

Comment thread src/sentry_sync.h Outdated

Comment thread src/sentry_scope.c

sentry Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/sentry_sync.h Outdated

jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 495cd85 to 05fe336 Compare August 7, 2026 14:42

jpnurmi changed the title ~~[WIP] perf: use recursive rwlock for global scope~~ [WIP] perf: use rwlock for scope data access Aug 7, 2026

sentry Bot reviewed Aug 7, 2026

View reviewed changes