ref: prevent direct access to scope data - #2083
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
jpnurmi
added this pull request to stack #2084
September 10, 2026 11:58
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2083 +/- ##
==========================================
- Coverage 74.68% 74.60% -0.08%
==========================================
Files 103 103
Lines 27039 27245 +206
Branches 4915 4928 +13
==========================================
+ Hits 20193 20327 +134
- Misses 5501 5577 +76
+ Partials 1345 1341 -4 🚀 New features to boost your workflow:
|
limbonaut
approved these changes
Sep 11, 2026
limbonaut
left a comment
limbonaut
left a comment
Collaborator
There was a problem hiding this comment.
I went through the whole change set. It's well structured and mostly mechanical shift, but because of the sheer size I might have missed some tiny speck. Ran a scan too. Looks good with one place worth considering a small alteration in behavior to avoid a potential future trap.
Move scope data out of the header to prevent direct access, and provide internal API tailored for protecting the data with RW-locks in #2024.
Clone the active span or transaction value instead of retaining its inner reference. This lets the returned value outlive finish without bypassing wrapper cleanup. Rename the accessor to load_span_or_transaction and cover both lifetimes with sanitizer regression tests.
jpnurmi
force-pushed
the
jpnurmi/ref/scope-data
branch
from
September 11, 2026 13:17
883f4a6 to
981087c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move scope data out of the header to prevent direct access, and provide internal API tailored for protecting the data with RW-locks in #2042. This offloads a lot of mechanical churn out of #2042, lets #2042 focus on getting the RW-locks right, and allows migrating the console SDKs.
See also: