feat(falcon): Set name and source on request span when streaming#6562
feat(falcon): Set name and source on request span when streaming#6562alexander-alderman-webb wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c17904. Configure here.
Codecov Results 📊✅ 89644 passed | ⏭️ 6019 skipped | Total: 95663 | Pass Rate: 93.71% | Execution Time: 301m 35s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 87.50%. Project has 2396 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.75% 89.79% +0.04%
==========================================
Files 192 192 —
Lines 23486 23465 -21
Branches 8066 8062 -4
==========================================
+ Hits 21079 21069 -10
- Misses 2407 2396 -11
- Partials 1329 1330 +1Generated by Codecov Action |
ericapisani
left a comment
There was a problem hiding this comment.
One question, but otherwise LGTM
| "path": req.path, | ||
| } | ||
| name = name_for_style[integration.transaction_style] | ||
| source = SOURCE_FOR_STYLE[integration.transaction_style] |
There was a problem hiding this comment.
If, based on my understanding of the pull request description, process_resource is intended t be run when span streaming is enabled, should this instead be using the SOURCE_FOR_STYLE from sentry_sdk.traces instead of sentry_sdk.tracing?

Description
Call
Scope.set_transaction_name()on the current scope inprocess_resource()to change the name and source of the segment span when span streaming is enabled.Issues
Closes #6019
Reminders
uv run ruff.feat:,fix:,ref:,meta:)