ref(asgi): Drop send_default_pii support in _get_request_data - #7768
Open
ericapisani wants to merge 2 commits into
Open
ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
Always filter the query string through the `data_collection` `url_query_params` setting. The legacy `send_default_pii` path is resolved into an equivalent `data_collection` default, so the raw query string is no longer passed through. Update the Django ASGI and FastAPI tests to configure `data_collection` instead of `send_default_pii`. Refs PY-2798 Refs #7566
…uest_data` Read `REMOTE_ADDR` from `data_collection["user_info"]` only. The client already resolves `send_default_pii` into `data_collection` at init, so the legacy `should_send_default_pii()` fallback is redundant. Update the ASGI and Django ASGI tests to configure `data_collection` instead of `send_default_pii`, and remove the legacy `send_default_pii` parametrized cases.
ericapisani
marked this pull request as ready for review
September 29, 2026 17:14
Contributor
Codecov Results 📊✅ 57310 passed | ❌ 1 failed | ⏭️ 2709 skipped | Total: 60020 | Pass Rate: 95.48% | Execution Time: 161m 4s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
ericapisani
added this pull request to stack #7770
September 29, 2026 17:25
ericapisani
removed this pull request from stack #7770
September 29, 2026 17:26
ericapisani
added this pull request to stack #7771
September 29, 2026 17:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always filter the query string through the
data_collectionurl_query_paramssetting. The legacysend_default_piipath isresolved into an equivalent
data_collectiondefault, so the rawquery string is no longer passed through.
Update the Django ASGI and FastAPI tests to configure
data_collectioninstead ofsend_default_pii.Refs PY-2798
Refs #7566