Skip to content

ref(asgi): Drop send_default_pii support in _get_request_attributes - #7769

Open
ericapisani wants to merge 1 commit into
py-2798-update-asgi-get-request-datafrom
py-2798-update-asgi-get-request-attributes
Open

ericapisani wants to merge 1 commit into
py-2798-update-asgi-get-request-datafrom
py-2798-update-asgi-get-request-attributes

Conversation

@ericapisani

@ericapisani ericapisani commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Remove the legacy send_default_pii fallback branches and always
gate http.query, url.path, url.full and client.address on
data_collection.

Refs PY-2798
Refs #7566

Remove the legacy `send_default_pii` fallback branches and always
gate `http.query`, `url.path`, `url.full` and `client.address` on
`data_collection`.

Refs PY-2798
Refs #7566
@ericapisani
ericapisani added this pull request to stack #7770 September 29, 2026 17:25
@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

PY-2798

@ericapisani
ericapisani removed this pull request from stack #7770 September 29, 2026 17:26
@ericapisani
ericapisani added this pull request to stack #7771 September 29, 2026 17:26
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 57303 passed | ❌ 1 failed | ⏭️ 2709 skipped | Total: 60013 | Pass Rate: 95.48% | Execution Time: 164m 43s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -76846
Passed Tests 📉 -72387
Failed Tests 📈 +1
Skipped Tests 📉 -4460

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.6.0
Error: KeyError: 139918047858688

Stack Trace
tests/integrations/mistral/test_mistral.py:389: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139918047858688

✅ Patch coverage is 100.00%. Project has 2064 uncovered lines.
❌ Project coverage is 90.07%. Comparing base (dbbc12b) to head (dc1aac6).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.25%    90.07%    -0.18%
==========================================
  Files          195       179       -16
  Lines        26195     20778     -5417
  Branches      9758      7298     -2460
==========================================
+ Hits         23641     18714     -4927
- Misses        2554      2064      -490
- Partials      1484      1220      -264

Generated by Codecov Action

@ericapisani
ericapisani marked this pull request as ready for review September 29, 2026 17:55
@ericapisani
ericapisani requested a review from a team as a code owner September 29, 2026 17:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant