ref(client)!: Remove EventScrubber and the event_scrubber option - #7772
Open
ericapisani wants to merge 3 commits into
Open
ericapisani wants to merge 3 commits into
ericapisani wants to merge 3 commits into
Conversation
`data_collection` is now the default way to control what data the SDK collects, so the always-on `EventScrubber` is no longer needed. Removes `sentry_sdk.scrubber` (`EventScrubber`, `DEFAULT_DENYLIST`, `DEFAULT_PII_DENYLIST`), the scrubbing step in `_prepare_event`, and the `event_scrubber` init option. Passing `event_scrubber=` to `init` now raises a `TypeError`. Refs PY-2798 Refs #7566
Contributor
Codecov Results 📊✅ 57188 passed | ❌ 1 failed | ⏭️ 2709 skipped | Total: 59898 | Pass Rate: 95.48% | Execution Time: 162m 56s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
The body is no longer redacted by `EventScrubber`, so assert the raw value. Opt into `data_collection` and disable flask_login, whose module-level login manager has no user_loader, so user info collection doesn't raise.
ericapisani
marked this pull request as ready for review
September 29, 2026 18:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data_collectionis now the default way to control what data the SDK collects, so the always-onEventScrubberis no longer needed. The expectation is that, if people need to filter out request bodies, etc., that they use thebefore_sendcallback.Removes
sentry_sdk.scrubber(EventScrubber,DEFAULT_DENYLIST,DEFAULT_PII_DENYLIST), the scrubbing step in_prepare_event, and theevent_scrubberinit option. Passingevent_scrubber=toinitnow raises aTypeError.Refs PY-2798
Refs #7566