Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
> make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first.
<!-- prettier-ignore-end -->

## Unreleased

### Fixes

- Fix Android Gradle source map upload being silently skipped on some occasions ([#6320](https://github.com/getsentry/sentry-react-native/pull/6320))

## 8.15.0

### Features
Expand Down
6 changes: 6 additions & 0 deletions packages/core/sentry.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -253,19 +253,25 @@ fun extractBundleTaskArguments(
val jsSourceMapsDir = (props["jsSourceMapsDir"] as? org.gradle.api.provider.Provider<*>)?.orNull
val jsIntermediateSourceMapsDir = (props["jsIntermediateSourceMapsDir"] as? org.gradle.api.provider.Provider<*>)?.orNull

// React Native's BundleHermesCTask declares `jsIntermediateSourceMapsDir` as a `RegularFileProperty`
// (and other versions may do the same for the bundle/sourcemap dirs) even though they hold a
// directory path, so accept both `Directory` and `RegularFile` here.
val bundleDirFile =
when (jsBundleDir) {
is org.gradle.api.file.Directory -> jsBundleDir.asFile
is org.gradle.api.file.RegularFile -> jsBundleDir.asFile
else -> return BundleTaskArgs(null, null, null, null)
}
val sourcemapsDirFile =
when (jsSourceMapsDir) {
is org.gradle.api.file.Directory -> jsSourceMapsDir.asFile
is org.gradle.api.file.RegularFile -> jsSourceMapsDir.asFile
else -> return BundleTaskArgs(null, null, null, null)
}
val intermediateSourcemapsDirFile =
when (jsIntermediateSourceMapsDir) {
is org.gradle.api.file.Directory -> jsIntermediateSourceMapsDir.asFile
is org.gradle.api.file.RegularFile -> jsIntermediateSourceMapsDir.asFile
else -> return BundleTaskArgs(null, null, null, null)
}

Expand Down
Loading