feat(snuba): record gauge for batch size. - #8300
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1b6e10c. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
phacops
reviewed
Aug 13, 2026
|
|
||
| counter!("insertions.batch_write_bytes", num_bytes as i64); | ||
| counter!("insertions.batch_write_msgs", batch_len as i64); | ||
| gauge!("insertions.batch_write_bytes", num_bytes as i64); |
phacops
reviewed
Aug 13, 2026
phacops
left a comment
phacops
left a comment
Contributor
There was a problem hiding this comment.
Do we need both the counters and the gauges in that case? I'd be down to remove the counters.
phacops
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add gauge metrics for per-batch rows and bytes on ClickHouse inserts.
How
gauges:insertions.batch_flush_msgsandinsertions.batch_flush_bytesWhy
batch_write_msgs,batch_write_bytes) get summed across aggregation intervals, making batch sizes look inflated at wider time windowsNotes
counters for throughputLinks