Shared/Python: #21935 follow up#21998
Merged
Merged
Conversation
…the dbscheme template.
…the dbscheme template.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR follows up on #21935 by ensuring YAML comment extraction is reflected in dbscheme sources that are generated from templates/prefixes, so affected extractors produce schemas consistent with the shared YAML libraries.
Changes:
- Add the
yaml_commentstable to the shared tree-sitter extractor dbscheme prefix. - Extend
@yaml_locatableto include@yaml_commentso comments can be associated with locations. - Mirror the same dbscheme updates in the Python extractor
dbscheme.templateto keep generated dbschemes in sync.
Show a summary per file
| File | Description |
|---|---|
| shared/tree-sitter-extractor/src/generator/prefix.dbscheme | Adds yaml_comments and updates @yaml_locatable so generated schemas support YAML comment locations. |
| python/extractor/semmle/dbscheme.template | Updates the Python extractor’s schema template to include yaml_comments and make comments locatable. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Contributor
Author
|
Locally, this appears to fix the problems we were observing. I'll go ahead and merge this so we can see if it fixes the problems on CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #21935 we added support for YAML comment extraction for all languages which support extraction YAML. However, it turns out there some languages generate the dbscheme from other files which I missed in that PR.
This PR fixes up these issues.