Rust: Exclude 'unused variable' results for functions containing todo!() or unimplemented!() - #22398
Open
hvitved wants to merge 2 commits into
Open
Rust: Exclude 'unused variable' results for functions containing todo!() or unimplemented!()#22398hvitved wants to merge 2 commits into
todo!() or unimplemented!()#22398hvitved wants to merge 2 commits into
Conversation
…o!()` or `unimplemented!()`
Contributor
There was a problem hiding this comment.
Pull request overview
Excludes unused-variable findings from Rust callables containing standard incomplete-code macros.
Changes:
- Recognizes resolved
todo!()andunimplemented!()macros. - Adds regression tests and a change note.
Show a summary per file
| File | Description |
|---|---|
UnusedVariable.qll |
Extends incomplete-callable detection. |
main.rs |
Tests both standard macros. |
| Change note | Documents the analysis improvement. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.