Skip to content

JS: Model the merge-descriptors library as a shallow extender #22401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 3 commits into from
Aug 21, 2026
+25 −11
Merged

JS: Model the merge-descriptors library as a shallow extender #22401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a37610
JS: Add 'merge-descriptors' test.
MathiasVP Aug 20, 2026
77877e0
JS: Model 'merge-descriptors' as a shallow extender and accept test c…
MathiasVP Aug 20, 2026
58c6e80
JS: Autoformat.
MathiasVP Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions javascript/ql/lib/semmle/javascript/Extend.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ private class ExtendCallShallow extends ExtendCall {
override predicate isDeep() { none() }
}

/** A shallow extend call of form `mergeDescriptors(dst, src)`. */
private class MergeDescriptorsCall extends ExtendCall {
MergeDescriptorsCall() { this = DataFlow::moduleImport("merge-descriptors").getACall() }

override DataFlow::Node getASourceOperand() { result = this.getArgument(1) }

override DataFlow::Node getDestinationOperand() { result = this.getArgument(0) }

override predicate isDeep() { none() }
}

/**
* A shallow extend call of form `extend(src1, src2, ...)`.
*/
Expand Down
23 changes: 12 additions & 11 deletions javascript/ql/test/library-tests/Extend/ExtendCalls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,18 @@
| tst.js:64:1:64:48 | checkSh ... arg())) | OK |
| tst.js:65:1:65:54 | checkSh ... arg())) | OK |
| tst.js:66:1:66:45 | checkSh ... arg())) | OK |
| tst.js:67:1:67:52 | checkSh ... arg())) | OK |
| tst.js:68:1:68:53 | checkSh ... arg())) | OK |
| tst.js:67:1:67:57 | checkSh ... arg())) | OK |
| tst.js:68:1:68:52 | checkSh ... arg())) | OK |
| tst.js:69:1:69:53 | checkSh ... arg())) | OK |
| tst.js:70:1:70:55 | checkSh ... arg())) | OK |
| tst.js:71:1:71:52 | checkSh ... arg())) | OK |
| tst.js:72:1:72:51 | checkSh ... arg())) | OK |
| tst.js:70:1:70:53 | checkSh ... arg())) | OK |
| tst.js:71:1:71:55 | checkSh ... arg())) | OK |
| tst.js:72:1:72:52 | checkSh ... arg())) | OK |
| tst.js:73:1:73:51 | checkSh ... arg())) | OK |
| tst.js:74:1:74:53 | checkSh ... arg())) | OK |
| tst.js:74:1:74:51 | checkSh ... arg())) | OK |
| tst.js:75:1:75:53 | checkSh ... arg())) | OK |
| tst.js:79:1:79:45 | checkSh ... arg())) | OK |
| tst.js:80:1:80:55 | checkSh ... arg())) | OK |
| tst.js:81:1:81:51 | checkSh ... arg())) | OK |
| tst.js:85:1:85:44 | checkDe ... arg())) | OK |
| tst.js:86:1:86:61 | checkDe ... arg())) | OK |
| tst.js:76:1:76:53 | checkSh ... arg())) | OK |
| tst.js:80:1:80:45 | checkSh ... arg())) | OK |
| tst.js:81:1:81:55 | checkSh ... arg())) | OK |
| tst.js:82:1:82:51 | checkSh ... arg())) | OK |
| tst.js:86:1:86:44 | checkDe ... arg())) | OK |
| tst.js:87:1:87:61 | checkDe ... arg())) | OK |
1 change: 1 addition & 0 deletions javascript/ql/test/library-tests/Extend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"lodash.mergewith": "^4.6.1",
"merge": "^1.2.0",
"merge-deep": "^3.0.2",
"merge-descriptors": "^1.0.3",
"merge-options": "^1.0.1",
"mixin-deep": "^2.0.0",
"mixin-object": "^3.0.0",
Expand Down
1 change: 1 addition & 0 deletions javascript/ql/test/library-tests/Extend/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ checkShallow(Object.assign(base(), arg()));
checkShallow(require("defaults")(base(), arg()));
checkShallow(require("extend-shallow")(base(), arg()));
checkShallow(require("merge")(base(), arg()));
checkShallow(require("merge-descriptors")(base(), arg()));
checkShallow(require("mixin-object")(base(), arg()));
checkShallow(require("object-assign")(base(), arg()));
checkShallow(require("object.assign")(base(), arg()));
Expand Down
Loading