Fix recurring merge queue failure causes - #2515
Conversation
Synchronize Go replay proxy startup, avoid nested PowerShell in the Windows shell E2E test, normalize bare abort results, retry truncated Python downloads, and prevent local Java validation from invoking Central publishing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SDK Consistency ReviewReviewed the full PR diff (7 files) against all six SDK implementations. Summary of changes:
Cross-SDK consistency assessment: The The Go E2E test change and the shared No action needed. This PR does not introduce any new public API in one language without a counterpart elsewhere, nor does it change SDK behavior inconsistently across languages. No inline comments added.
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused reliability fixes are consistent with their surrounding implementations and include appropriate validation coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Fixes recurring merge-queue failures across replay handling, Python downloads, Go E2E setup, and Java validation.
Changes:
- Normalizes aborted tool results and retries truncated downloads.
- Stabilizes Go proxy initialization and Windows shell execution.
- Prevents Java local validation from publishing to Maven Central.
| File | Description |
|---|---|
test/harness/replayingCapiProxy.ts |
Normalizes bare session-abort results. |
test/harness/replayingCapiProxy.test.ts |
Tests abort-result normalization. |
python/copilot/_cli_download.py |
Retries incomplete HTTP reads. |
python/test_cli_download.py |
Tests truncated-response recovery. |
go/internal/e2e/testharness/context.go |
Initializes the replay proxy before clients start. |
go/internal/e2e/rpc_shell_and_fleet_e2e_test.go |
Stabilizes Windows shell marker execution. |
.github/workflows/java-sdk-tests.yml |
Explicitly disables Maven Central publication. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Repeated merge-queue attempts for #2507 exposed several independent SDK test and CI defects: replay mismatches after aborts, uninitialized proxy traffic, fragile Windows shell execution, truncated Python downloads, and accidental Maven Central publication during local validation.
Changes
Session abortedresult to the replay harness's stable interruption representation.cmd.exein an isolated working directory instead of nested PowerShell.http.client.IncompleteReadfailures while continuing to verify complete downloads with checksums or package integrity metadata.skipPublishingduring Java native local publication validation so release-version commits do not require Maven Central credentials.The MCP OAuth startup race is intentionally excluded because github/copilot-agent-runtime#18931 and #2511 already own that work. This also complements #2484, which improved teardown, diagnostics, artifact reruns, and registry retries but did not cover these failure modes.
Validation
Generated by Copilot