test(nvx): gate Linux-specific cases - #8815
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The mixed filesystem test must be split so platform-independent constructor validation remains covered on non-Linux hosts.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Gates NVX tests that depend on Linux-specific /proc and descriptor traversal behavior.
Changes:
- Adds reusable
linuxIttest guards. - Skips four Linux-dependent NVX tests on other platforms.
- One mixed test also unintentionally skips platform-independent validation.
| File | Description |
|---|---|
src/nvx/one-shot-adapter.test.ts |
Gates /proc-dependent process-group escalation test. |
src/nvx/filesystem-builder.test.ts |
Gates descriptor-traversal filesystem tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }); | ||
|
|
||
| it('rejects escaping symlinks, duplicate roles, and unsafe run identifiers', async () => { | ||
| linuxIt('rejects escaping symlinks, duplicate roles, and unsafe run identifiers', async () => { |
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Collaborator
Author
|
@copilot address review feedback |
Contributor
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/procenumerationValidation
npm test -- --runInBand(377 suites passed; 6046 tests passed, 4 Linux-only tests skipped)npm run type-checknpm run lint -- --quiet