Normalize replayed apply_patch function-call IDs by Copilot · Pull Request #8944 · github/gh-aw-firewall

Copilot · 2026-09-24T01:22:36Z

Copilot rejects replayed Responses function_call items whose id still uses the Codex custom-tool ctc_ prefix. The compatibility adapter converted replayed apply_patch calls to function_call but preserved the invalid item ID, causing retries to fail on the same history.

Request compatibility
- Rewrites translated apply_patch item IDs from ctc_* to fc_*.
- Preserves call_id, so paired function_call_output items still match the call.

{
  type: 'custom_tool_call',
  id: 'ctc_call_example',
  call_id: 'call_example',
  name: 'apply_patch'
}
// becomes
{
  type: 'function_call',
  id: 'fc_call_example',
  call_id: 'call_example',
  name: 'apply_patch'
}

Regression coverage
- Covers replayed apply_patch history with ctc_ IDs.
- Covers next-turn replay after file creation.
- Verifies existing fc_ IDs, absent IDs, ordinary function calls, and call/output identity remain unchanged.

Fixes Copilot Responses: replayed apply_patch retains ctc_ ID after conversion to function_call #8935

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot

Copilot review overview

🟢 Approval recommended

The targeted fix is correct and covers the reported replay scenarios without altering unrelated calls.

Review effort: Balanced
Findings: None

What changed in this PR

Normalizes replayed apply_patch calls for Copilot Responses compatibility.

Changes:

Converts ctc_* item IDs to fc_* while preserving call_id.
Adds regression coverage for replayed calls and unchanged valid IDs.

File	Description
`containers/api-proxy/codex-compat.js`	Normalizes translated function-call IDs.
`containers/api-proxy/codex-compat.test.js`	Tests normalization and identity preservation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-09-24T01:32:49Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-09-24T01:51:42Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
example.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-09-24T01:51:42Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-09-24T01:51:42Z

❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-09-24T01:51:46Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

Warning

Firewall blocked 12 domains

The following domains were blocked by the firewall during workflow execution:

ab.chatgpt.com
accounts.google.com
api.github.com
clients2.google.com
collector.github.com
contentautofill.googleapis.com
github.com
github.githubassets.com
msfeed25.pkgs.visualstudio.com
update.googleapis.com
www.google.com
www.gstatic.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "accounts.google.com"
    - "api.github.com"
    - "clients2.google.com"
    - "collector.github.com"
    - "contentautofill.googleapis.com"
    - "github.com"
    - "github.githubassets.com"
    - "msfeed25.pkgs.visualstudio.com"
    - "update.googleapis.com"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-09-24T01:51:46Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-09-24T01:51:48Z

❌ Smoke Gemini reports failed. Facets need polishing...

Warning

Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
github.com
play.googleapis.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"
    - "play.googleapis.com"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-09-24T01:51:48Z

✅ Smoke Claude passed

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.anthropic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"

See Network Configuration for more information.

Generated by Smoke Claude for #8944

github-actions · 2026-09-24T01:51:50Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-09-24T01:51:51Z

Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

example.com
github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"
    - "github.com"

See Network Configuration for more information.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-09-24T01:51:51Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

o205451.ingest.us.sentry.io
registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "o205451.ingest.us.sentry.io"
    - "registry.npmjs.org"

See Network Configuration for more information.

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-09-24T01:51:53Z

✅ Build Test Suite completed successfully!

Warning

Firewall blocked 8 domains

The following domains were blocked by the firewall during workflow execution:

api.nuget.org
bun.sh
dc.services.visualstudio.com
deno.land
dl.deno.land
github.com
releaseassets.githubusercontent.com
repo.maven.apache.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.nuget.org"
    - "bun.sh"
    - "dc.services.visualstudio.com"
    - "deno.land"
    - "dl.deno.land"
    - "github.com"
    - "releaseassets.githubusercontent.com"
    - "repo.maven.apache.org"

See Network Configuration for more information.

Generated by Build Test Suite for #8944

github-actions · 2026-09-24T01:51:53Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-09-24T01:51:56Z

✅ Security Guard completed successfully!

Security review of PR #8944: No security concerns found. The change normalizes function-call IDs in the API proxy compatibility layer (containers/api-proxy/codex-compat.js) by transforming ctc_ prefixes to fc_ format. This is a cosmetic transformation with no impact on firewall rules, network access controls, capabilities, seccomp profiles, input validation, or credential handling. PR passes security review.

Generated by Security Guard for #8944

github-actions · 2026-09-24T01:52:04Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-09-24T01:54:37Z

Smoke Test: Copilot Engine

✅ GitHub MCP: connected (e.g. PR Enforce AWF domain policy on Claude hosted web search and fetch #8929, PR Document explicit upstream proxy port fix in runner-doctor B2 catalog #8925)
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test

Overall: PASS

cc @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:54:39Z

Smoke Test: Cloud Hypervisor + Copilot

list_pull_requests (merged) — PASS
curl https://github.com → 200 — PASS
Write/read /tmp/gh-aw/agent/smoke-cloud-hypervisor-*.txt — PASS
curl (example.com/redacted) → 000 (blocked) — PASS

Result: ALL PASS

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

example.com
github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"
    - "github.com"

See Network Configuration for more information.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:55:04Z

Smoke Test: Copilot BYOK Mode ✅ PASS

✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test
✅ GitHub MCP connectivity
✅ Direct BYOK inference (COPILOT_PROVIDER_API_KEY mode)

Running in direct BYOK mode via api-proxy sidecar → api.githubcopilot.com

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:55:05Z

Copilot Network Isolation Smoke Test @lpcox

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com): reachable, allowed=200
✅ Blocked domain (example.com): blocked (TLS intercept denial), denied=000

Overall: PASS

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
example.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:55:45Z

Smoke Test: Services Connectivity

Redis PING: ✅ PONG
PostgreSQL pg_isready: ✅ accepting connections
PostgreSQL SELECT 1: ✅ 1

Overall: PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:55:52Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
GitHub CLI	✅ PASS
File	✅ PASS

Overall result: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.anthropic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"

See Network Configuration for more information.

Generated by Smoke Claude for #8944 · claude · haiku45 · 29.9 AIC · ⊞ 4.7K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:56:39Z

Smoke Test: API Proxy OpenTelemetry Tracing — All Scenarios Pass ✅

#	Scenario	Result
1	Module Loading	✅ `otel.js` loads successfully; `isEnabled(): true`; exports `startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled` + internal test hooks
2	Test Suite	✅ 3 suites, 68/68 tests passed (`otel.test.js`, `otel-fanout.test.js`, `otel-workload-identity.test.js`) — covers span creation, gen_ai token attributes, OTLP serialization, workload identity, fan-out export
3	Env Var Forwarding	✅ `env-passthrough.ts` forwards `GITHUB_AW_OTEL_TRACE_ID` and `GITHUB_AW_OTEL_PARENT_SPAN_ID` to the agent; `api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, and the same trace context vars to api-proxy
4	Token Tracker Integration	✅ `onUsage` callback present in `token-tracker-http.js` as the OTEL hook point
5	OTEL Diagnostics	✅ `/tmp/gh-aw/otel.jsonl` contains exported resourceSpans (e.g. `gh-aw.agent.setup` span) confirming workflow-level OTLP export is functioning

No unexpected failures. OTEL tracing integration in the api-proxy sidecar is working as designed.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

o205451.ingest.us.sentry.io
registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "o205451.ingest.us.sentry.io"
    - "registry.npmjs.org"

See Network Configuration for more information.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:56:58Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.14	Python 3.12.14	✅ YES
Node.js	v24.21.0	v22.23.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: FAILED — Node.js version mismatch between host and chroot environments. The smoke-chroot label will not be added since not all runtimes match.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-09-24T01:57:00Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A (run OK)	✅ PASS
.NET	json-parse	✅	N/A (run OK)	✅ PASS
Go	color	✅	ok	✅ PASS
Go	env	✅	ok	✅ PASS
Go	uuid	✅	ok	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note: Maven's default ~/.m2/repository directory was not writable in this sandbox environment (owned by root), so Java builds used -Dmaven.repo.local=/tmp/gh-aw/agent/m2-repo as a local repository override. This is an environment workaround unrelated to the firewall itself, and both Java projects compiled and passed tests successfully once applied.

Warning

Firewall blocked 8 domains

The following domains were blocked by the firewall during workflow execution:

api.nuget.org
bun.sh
dc.services.visualstudio.com
deno.land
dl.deno.land
github.com
releaseassets.githubusercontent.com
repo.maven.apache.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.nuget.org"
    - "bun.sh"
    - "dc.services.visualstudio.com"
    - "deno.land"
    - "dl.deno.land"
    - "github.com"
    - "releaseassets.githubusercontent.com"
    - "repo.maven.apache.org"

See Network Configuration for more information.

Generated by Build Test Suite for #8944 · copilot · auto · 30 AIC · ⊞ 11.8K · ◷
_{Add label ready-for-aw to run again}

Initial plan

b35c1f3

Copilot AI assigned Copilot and lpcox Sep 24, 2026

Copilot started work on behalf of lpcox September 24, 2026 01:23 View session

Copilot AI linked an issue Sep 24, 2026 that may be closed by this pull request

Copilot Responses: replayed apply_patch retains ctc_ ID after conversion to function_call #8935

Closed

fix(api-proxy): normalize replayed apply_patch function ids

b56bc29

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix ctc_ ID retention after function call conversion~~ Normalize replayed apply_patch function-call IDs Sep 24, 2026

Copilot finished work on behalf of lpcox September 24, 2026 01:29

Copilot AI requested a review from lpcox September 24, 2026 01:29

lpcox marked this pull request as ready for review September 24, 2026 01:30

Copilot AI balanced review requested due to automatic review settings September 24, 2026 01:30

Copilot started reviewing on behalf of lpcox September 24, 2026 01:30 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

lpcox added the ready-for-aw label Sep 24, 2026

lpcox had a problem deploying to aoai-model September 24, 2026 01:51 — with GitHub Actions Failure

github-actions Bot added the smoke-copilot label Sep 24, 2026

github-actions Bot added the smoke-cloud-hypervisor label Sep 24, 2026

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Sep 24, 2026

github-actions Bot added the smoke-copilot-byok label Sep 24, 2026

github-actions Bot added the smoke-services label Sep 24, 2026

github-actions Bot added the smoke-claude label Sep 24, 2026

lpcox deployed to aoai-model September 24, 2026 01:55 — with GitHub Actions Active

lpcox deployed to aoai-model September 24, 2026 01:56 — with GitHub Actions Active

lpcox enabled auto-merge (squash) September 24, 2026 01:56

github-actions Bot added the build-test label Sep 24, 2026

github-actions Bot mentioned this pull request Sep 24, 2026

[aw] Smoke Gemini failed #8947

Closed

lpcox merged commit 57fdaa1 into main Sep 24, 2026
141 of 149 checks passed

lpcox deleted the copilot/fix-ctc-id-preservation branch September 24, 2026 02:04

github-actions Bot mentioned this pull request Sep 24, 2026

Enforce AWF domain policy on Codex hosted web search #8945

Merged

Conversation

Copilot AI commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Smoke Test: Cloud Hypervisor + Copilot

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Sep 24, 2026

Smoke Test: API Proxy OpenTelemetry Tracing — All Scenarios Pass ✅

Uh oh!

github-actions Bot commented Sep 24, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Sep 24, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Copilot AI commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading

github-actions Bot commented Sep 24, 2026 •

edited

Loading