Skip to content

[docs] auth: auth: correct stale host-routing wiring status in awf-config-spec.md - #9034

Merged
lpcox merged 3 commits into
mainfrom
docs/routing-host-wiring-shipped-20260926-3148511e369c6391
Sep 26, 2026
Merged

lpcox merged 3 commits into
mainfrom
docs/routing-host-wiring-shipped-20260926-3148511e369c6391

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Documentation Changes

  • docs/awf-config-spec.md (§13a) — Replaced the "host workflow does not yet stage or validate" paragraph (which cited PR Wire task-level model routing into the host workflow #8985 as open) with an accurate description: the host now stages the trusted conversation into a private per-run routing directory, rejects unsupported host modes (non-Linux, non-runc, disabled API proxy, DinD/split filesystems, Docker-socket exposure, unpinned router image), and waits for selection.json before starting the agent; a routing failure from either side surfaces as host exit code 78.

Validation

  • Implementation/tests checked: src/routing/bootstrap.ts (stageRoutingConversation, RoutingFailureExitError with exitCode = 78, ROUTING_SELECTION_TIMEOUT_MS, digest-pin check via isDigestPinnedImageReference), src/cli-workflow.ts (dependencies.prepareRouting, waitForRoutingSelection, verifyRoutingCompletion all invoked in the run flow), src/services/api-proxy-env-config.ts (buildModelRoutingEnv now requires config.modelRoutingBootstrap and throws MODEL_ROUTING_NOT_STAGED_MESSAGE if routing is configured without host staging having run).
  • Markdown/link review: diff limited to one paragraph in §13a; verified the [PR #8966](...) / [PR #8985](...) links render correctly and match the file's existing convention for citing merged PRs; surrounding code fence and table were left untouched.
  • Credential-leakage diff review: diff scanned for key/token/JWT/header patterns (sk-, ghp_, gho_, Authorization:, bearer-shaped strings) — none present; only prose and existing PR URLs were changed.

Sources

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • msfeed25.pkgs.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "msfeed25.pkgs.visualstudio.com"

See Network Configuration for more information.

Generated by Auth Doctor Updater · copilot · auto · 82.5 AIC · ⊞ 11.8K · ◷

PR #8985 (host-side routing bootstrap) merged 2026-09-25 and is fully wired
into src/cli-workflow.ts and src/routing/bootstrap.ts on main. The spec
still described host staging/validation as not-yet-merged; update it to
reflect that both the proxy-side (PR #8966) and host-side (PR #8985)
halves of task-level routing are shipped.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added ai-generated documentation Improvements or additions to documentation labels Sep 26, 2026
@lpcox
lpcox requested a balanced review from Copilot September 26, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The unsupported-configuration list omits the rejected --keep-containers option.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates the model-routing specification to reflect shipped host-side routing support.

Changes:

  • Documents routing input staging, validation, readiness waiting, and exit code 78.
  • Updates PR #8985’s status from pending to shipped.
File Description
docs/​awf-config-spec.md Corrects task-level routing workflow documentation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/awf-config-spec.md Outdated
The host workflow now validates `apiProxy.routing` input and handles unsupported configurations, improving error handling.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor Author

✅ Copilot review passed with no inline comments.

@github-actions[bot] Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Documentation Preview

Documentation has been built for this PR.

Download preview artifact

To view locally:

  1. Download the docs-preview-pr-9034 artifact from the workflow run
  2. Unzip and open index.html in your browser

Built from commit bd0a4e9

@lpcox

lpcox commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

@copilot merge main and resolve conflicts

…ing-shipped-20260926-3148511e369c6391

# Conflicts:
#	docs/awf-config-spec.md

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@copilot merge main and resolve conflicts

Merged current main and resolved the docs/awf-config-spec.md conflict in merge commit 2ade06a. The build and all 6,348 tests pass.

Copilot AI requested a review from lpcox September 26, 2026 17:07
@lpcox
lpcox merged commit 51c5110 into main Sep 26, 2026
16 of 17 checks passed
@lpcox
lpcox deleted the docs/routing-host-wiring-shipped-20260926-3148511e369c6391 branch September 26, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants