Skip to content

Upload activation run info as a GHE-compatible artifact - #60057

Merged
pelikhan merged 11 commits into
mainfrom
copilot/add-activation-job-upload-artifact
Sep 11, 2026
Merged

Upload activation run info as a GHE-compatible artifact#60057
pelikhan merged 11 commits into
mainfrom
copilot/add-activation-job-upload-artifact

Conversation

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Activation jobs need to publish aw_info.json as an archived artifact named info, including on GitHub Enterprise where unarchived artifacts are unsupported.

Changes

  • Artifact upload

    • Adds an Upload info artifact activation step.
    • Uploads /tmp/gh-aw/aw_info.json with one-day retention.
    • Preserves archive packaging by omitting unarchived-artifact options.
  • GitHub Enterprise compatibility

    • Resolves actions/upload-artifact through the existing GHES-aware action pinning.
    • Applies workflow-call artifact prefixes to avoid naming collisions.
- name: Upload info artifact
  uses: actions/upload-artifact@…
  with:
    name: info
    path: /tmp/gh-aw/aw_info.json
    retention-days: 1
  • Generated workflows
    • Recompiles lock files to include the new activation step.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.8 AIC · ⊞ 9.3K ·
Comment /souschef to run again



✨ PR Review Safe Output Test - Run 34545875328

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • clients2.google.com
  • mtalk.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"
    - "mtalk.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 82.3 AIC · ⌖ 17 AIC · ⊞ 7.8K ·
Comment /smoke-claude to run again


Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 28.9 AIC · ⊞ 9.3K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review September 10, 2026 21:34
Copilot AI balanced review requested due to automatic review settings September 10, 2026 21:34
Copilot AI changed the title Upload activation run info artifact Upload activation run info as a GHE-compatible artifact Sep 10, 2026
Copilot AI requested a review from pelikhan September 10, 2026 21:35
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot Update the logs command to first try downloading the info artifact and query the AWJSON file. If that fails, it can download the activation artifact, which is larger. The goal is for the logs command, or JSON-AWLogs, to download a small file containing information about the run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The byte-for-byte WASM golden fixtures were not regenerated and will fail existing golden tests.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a GHES-compatible archived info artifact containing activation run metadata.

Changes:

  • Adds the InfoArtifactName constant and compiler upload step.
  • Uses GHES-aware action pinning and workflow-call prefixes.
  • Regenerates 299 workflow lock files.
File summaries
File Description
pkg/constants/job_constants.go Defines the info artifact name.
pkg/constants/constants_test.go Verifies the constant value.
pkg/workflow/compiler_activation_outputs.go Generates the archived info upload step.
pkg/workflow/compiler_activation_job_test.go Tests standard and GHES uploads.
.changeset/patch-activation-info-artifact.md Documents the patch.
.github/workflows/*.lock.yml (299 files) Adds the generated activation info upload step.
Review details
  • Files reviewed: 300/304 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread pkg/workflow/compiler_activation_outputs.go
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch PR file list

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • api.github.com
  • github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Code Quality Reviewer failed during code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Cannot review PR #60057: /tmp/gh-aw/agent/pr-diff.patch is empty (0 bytes), so there are no changed lines to assess for over-engineering.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #60057

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

⚠️ Security scanning failed for Design Decision Gate 🏗️. Review the logs for details.

No ADR enforcement needed: PR does not have the 'implementation' label and has <=100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please address the latest blocking signals on this PR:

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 8.33 AIC · ⊞ 9.3K ·
Comment /souschef to run again

@pelikhan

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /codebase-design — commenting on one duplication concern, no blocking issues.

📋 Key Themes & Highlights

Key Themes

  • Redundant upload: aw_info.json is now packaged in both the new info artifact and the existing activation artifact, doubling per-run upload bytes for the same content with nothing enforcing they stay identical.
  • Tests (TestActivationInfoArtifactUpload) correctly cover both the archived-artifact contract (no skip-archive/unarchived-artifact) and the GHES-compatible action pin — good /tdd discipline here.
  • constants_test.go and job_constants.go additions are consistent with the existing ArtifactName pattern.

Positive Highlights

  • ✅ Clear separation via addActivationInfoArtifactUploadStep, keeping the new step's logic isolated from addActivationArtifactUploadStep.
  • path.Join cleanup for sub-agent/skill dirs is a nice incidental correctness fix.
  • ✅ Regenerated lock files are consistent across all workflows (verified ab-testing-advisor.lock.yml step ordering).

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • api.github.com
  • github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 65.4 AIC · ⌖ 14.9 AIC · ⊞ 10.3K
Comment /matt to run again

Comment thread pkg/workflow/compiler_activation_outputs.go
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Update the logs command to first try downloading the info artifact and query the AWJSON file. If that fails, it can download the activation artifact, which is larger. The goal is for the `l...

Implemented in 4e47be4. logs and the MCP logs tool now default to info; they fetch its aw_info.json first and fall back to the activation artifact when it is unavailable.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run pr-finisher skill

Completed the pr-finisher validation flow in 40f2f99: local formatting, linting, unit tests, full tests, recompilation, WASM tests, and fixture regeneration all pass.

@copilot fix https://github.com/github/gh-aw/actions/runs/34532986637/job/103060647053?pr=60057

Fixed in 40f2f99. The reported WASM golden failure is resolved by regenerating the fixtures; local WASM golden and binary tests pass.

Copilot AI requested a review from gh-aw-bot September 11, 2026 04:43
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

Copilot AI and others added 2 commits September 11, 2026 05:03
…n-job-upload-artifact

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot merge main and recompile

Merged current main in 9bc8d4b and regenerated the stale workflow lock file in bec7c9d. make agent-report-progress passes.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/34576660531

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 23.4 AIC · ⊞ 8.9K ·
Comment /souschef to run again

Copilot AI and others added 2 commits September 11, 2026 08:12
…n-job-upload-artifact

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before ...

The referenced PR Sous Chef run completed successfully with no failed jobs. I refreshed main in 7eb9608 and recompiled generated outputs in a92710e; make agent-report-progress passes.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/34579367023

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 17.4 AIC · ⊞ 9.3K ·
Comment /souschef to run again

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before ...

Run 34579367023 completed successfully: all 10 jobs passed and it has no failed-job logs. main is already merged at the current PR HEAD; the only current check is the in-progress Copilot follow-up.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot These items still need follow-up on this PR:

Please address the remaining review state, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/34581583531

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 45.9 AIC · ⊞ 9.3K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot These items still need follow-up on this PR:

The three implementation threads are now resolved. I addressed and replied to both remaining GitHub Actions changeset threads in 28cac3c; the GHES action version is documented. The compact report run has no failed jobs, and current main is already merged. Thread resolution is not exposed by the available API tools.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot The remaining GitHub Actions review threads appear to have author replies but may still need explicit resolution. Please resolve the remaining review state, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers.

Run: https://github.com/github/gh-aw/actions/runs/34589658410

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 42.4 AIC · ⊞ 8.9K ·
Comment /souschef to run again

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot The remaining GitHub Actions review threads appear to have author replies but may still need explicit resolution. Please resolve the remaining review state, refresh the branch if needed, and ...

Verified the review state: all five referenced threads are now resolved. Run 34589658410 also completed successfully with all 10 jobs passing and no failed-job logs; the worktree is clean and main remains merged.

@pelikhan
pelikhan merged commit 1b18da1 into main Sep 11, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/add-activation-job-upload-artifact branch September 11, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants