Upload activation run info as a GHE-compatible artifact - #60057
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot Update the |
There was a problem hiding this comment.
🟡 Changes recommended
The byte-for-byte WASM golden fixtures were not regenerated and will fail existing golden tests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a GHES-compatible archived info artifact containing activation run metadata.
Changes:
- Adds the
InfoArtifactNameconstant and compiler upload step. - Uses GHES-aware action pinning and workflow-call prefixes.
- Regenerates 299 workflow lock files.
File summaries
| File | Description |
|---|---|
pkg/constants/job_constants.go |
Defines the info artifact name. |
pkg/constants/constants_test.go |
Verifies the constant value. |
pkg/workflow/compiler_activation_outputs.go |
Generates the archived info upload step. |
pkg/workflow/compiler_activation_job_test.go |
Tests standard and GHES uploads. |
.changeset/patch-activation-info-artifact.md |
Documents the patch. |
.github/workflows/*.lock.yml (299 files) |
Adds the generated activation info upload step. |
Review details
- Files reviewed: 300/304 changed files
- Comments generated: 1
- Review effort level: Balanced
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch PR file list
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
[!TIP] tools:
github:
mode: gh-proxySee GitHub Tools for more information on To allow these domains, add them to the network:
allowed:
- defaults
- "api.github.com"
- "github.com"See Network Configuration for more information.
|
|
Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details.
|
|
✅ Ponytail Reviewer completed successfully! Cannot review PR #60057: /tmp/gh-aw/agent/pr-diff.patch is empty (0 bytes), so there are no changed lines to assess for over-engineering. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "ab.chatgpt.com"See Network Configuration for more information.
|
|
No ADR enforcement needed: PR does not have the 'implementation' label and has <=100 new lines of code in business logic directories.
|
|
@copilot Please address the latest blocking signals on this PR:
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — commenting on one duplication concern, no blocking issues.
📋 Key Themes & Highlights
Key Themes
- Redundant upload:
aw_info.jsonis now packaged in both the newinfoartifact and the existingactivationartifact, doubling per-run upload bytes for the same content with nothing enforcing they stay identical. - Tests (
TestActivationInfoArtifactUpload) correctly cover both the archived-artifact contract (noskip-archive/unarchived-artifact) and the GHES-compatible action pin — good/tdddiscipline here. constants_test.goandjob_constants.goadditions are consistent with the existingArtifactNamepattern.
Positive Highlights
- ✅ Clear separation via
addActivationInfoArtifactUploadStep, keeping the new step's logic isolated fromaddActivationArtifactUploadStep. - ✅
path.Joincleanup for sub-agent/skill dirs is a nice incidental correctness fix. - ✅ Regenerated lock files are consistent across all workflows (verified
ab-testing-advisor.lock.ymlstep ordering).
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
api.github.comgithub.com
[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:
tools:
github:
mode: gh-proxySee GitHub Tools for more information on gh-proxy mode.
To allow these domains, add them to the network.allowed list in your workflow frontmatter:
network:
allowed:
- defaults
- "api.github.com"
- "github.com"See Network Configuration for more information.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 65.4 AIC · ⌖ 14.9 AIC · ⊞ 10.3K
Comment /matt to run again
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented in 4e47be4. |
|
@copilot run pr-finisher skill |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Completed the pr-finisher validation flow in 40f2f99: local formatting, linting, unit tests, full tests, recompilation, WASM tests, and fixture regeneration all pass.
Fixed in 40f2f99. The reported WASM golden failure is resolved by regenerating the fixtures; local WASM golden and binary tests pass. |
|
@copilot merge main and recompile |
…n-job-upload-artifact Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers. Run: https://github.com/github/gh-aw/actions/runs/34576660531
|
…n-job-upload-artifact Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
The referenced PR Sous Chef run completed successfully with no failed jobs. I refreshed |
|
@copilot The compact report still shows this PR needs follow-up. Please inspect any remaining blocking review or automation signals, refresh the branch if needed, and run the pr-finisher skill before handing this back to maintainers. Run: https://github.com/github/gh-aw/actions/runs/34579367023
|
Run 34579367023 completed successfully: all 10 jobs passed and it has no failed-job logs. |
|
@copilot These items still need follow-up on this PR:
Please address the remaining review state, refresh the branch if needed, and run the Run: https://github.com/github/gh-aw/actions/runs/34581583531 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
The three implementation threads are now resolved. I addressed and replied to both remaining GitHub Actions changeset threads in 28cac3c; the GHES action version is documented. The compact report run has no failed jobs, and current |
|
@copilot The remaining GitHub Actions review threads appear to have author replies but may still need explicit resolution. Please resolve the remaining review state, refresh the branch if needed, and run the Run: https://github.com/github/gh-aw/actions/runs/34589658410
|
Verified the review state: all five referenced threads are now resolved. Run 34589658410 also completed successfully with all 10 jobs passing and no failed-job logs; the worktree is clean and |
Activation jobs need to publish
aw_info.jsonas an archived artifact namedinfo, including on GitHub Enterprise where unarchived artifacts are unsupported.Changes
Artifact upload
Upload info artifactactivation step./tmp/gh-aw/aw_info.jsonwith one-day retention.GitHub Enterprise compatibility
actions/upload-artifactthrough the existing GHES-aware action pinning.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
✨ PR Review Safe Output Test - Run 34545875328
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
clients2.google.commtalk.google.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.