Skip to content

upgrade to node24 and use issue forms - #140

Merged
lindluni merged 2 commits into
mainfrom
node24
Sep 21, 2026
Merged

lindluni merged 2 commits into
mainfrom
node24

Conversation

@robandpdx

Copy link
Copy Markdown
Collaborator

This pull request modernizes and simplifies the process for requesting marketplace actions by migrating from legacy markdown-based issue templates to GitHub's YAML issue forms, updating documentation, and upgrading Node.js and related tooling across development and CI environments. The changes streamline user experience, improve automation reliability, and update dependencies for better maintainability.

Issue request workflow modernization:

  • Replaced the old markdown-based issue template (request_marketplace_action.md) with a new YAML issue form (request_marketplace_action.yml), allowing users to submit requests through structured form fields instead of manually pasting JSON blocks. [1] [2]
  • Updated workflow parsing logic in .github/workflows/approve-or-deny-request.yml and .github/workflows/initialize-request.yml to use the new issue-ops/parser action instead of the deprecated issue-body-parser-action, ensuring compatibility with the new issue form structure. [1] [2]
  • Improved validation conditions in workflows to check for non-empty parsed fields rather than presence of a JSON payload marker. [1] [2]

Documentation updates:

  • Revised README.md and examples.md to reflect the new issue request process, replacing markdown JSON snippets with clear instructions and tabular examples for the new form-based workflow. [1] [2]
  • Updated references to required workflow actions in documentation to match the new parser action.

Development and CI environment upgrades:

  • Upgraded Node.js version from 20 to 24 in all GitHub Actions workflows (test.yml, pr.yml, approve-or-deny-request.yml, initialize-request.yml) and in the devcontainer configuration for local development. [1] [2] [3] [4] [5] [6]
  • Updated devcontainer base image and documentation links to use the latest sources and Node.js version. [1] [2]

@robandpdx
robandpdx requested a review from a team as a code owner September 21, 2026 18:44
Copilot AI balanced review requested due to automatic review settings September 21, 2026 18:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The form parser integration, workflow expressions, pinned actions, documentation, and Node.js upgrade are consistent and validated by passing checks.

Review effort: Balanced
Findings: None

What changed in this PR

Modernizes marketplace-action requests with structured issue forms and Node.js 24.

Changes:

  • Replaces JSON-based issue templates with YAML issue forms and parser integration.
  • Updates request documentation and examples.
  • Upgrades CI and development environments to Node.js 24.
File Description
README.md Documents the form-based request process.
examples.md Shows example form values.
.github/​workflows/​test.yml Tests with Node.js 24.
.github/​workflows/​pr.yml Runs PR checks with Node.js 24.
.github/​workflows/​initialize-request.yml Parses and validates issue forms.
.github/​workflows/​approve-or-deny-request.yml Parses form data during approval.
.github/​ISSUE_TEMPLATE/​request_marketplace_action.yml Defines the structured request form.
.github/​ISSUE_TEMPLATE/​request_marketplace_action.md Removes the legacy template.
.devcontainer/​Dockerfile Uses the Node.js 24 devcontainer image.
.devcontainer/​devcontainer.json Configures the Node.js 24 variant.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lindluni
lindluni merged commit 5bf5817 into main Sep 21, 2026
5 checks passed
@lindluni
lindluni deleted the node24 branch September 21, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants