fix: use reshape instead of raw shape assignment for numpy arrays#539
Open
Trenza1ore wants to merge 1 commit into
Open
fix: use reshape instead of raw shape assignment for numpy arrays#539Trenza1ore wants to merge 1 commit into
Trenza1ore wants to merge 1 commit into
Conversation
NumPy 2.5.0 deprecated assignment to shape attribute
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5.0 deprecated assignment to shape attribute: numpy/numpy#29536
np.reshape(...)andnp.ndarray.reshape(...)did not supportcopy=Falseuntilnumpy>=2.1, therefore for compatibility's sake, I decided to just usenp.reshape(shape).This should be equivalent to the default
copy=Noneinnumpy>=2.1:Closes #540