fix(sessions): trim session id before the in-memory duplicate check - #6891
Open
leilei3167 wants to merge 1 commit into
Open
fix(sessions): trim session id before the in-memory duplicate check#6891leilei3167 wants to merge 1 commit into
leilei3167 wants to merge 1 commit into
Conversation
create_session checked the raw id, then stripped it and stored under the trimmed key, so a padded id overwrote the existing session. Normalize first, matching sqlite. Fixes google#6887
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InMemorySessionService.create_session()checked the rawsession_idfor duplicates, then stripped it and stored under the trimmed key. A whitespace-padded id (order-42\n) therefore overwrote the existing session instead of raisingAlreadyExistsError.Trim the id first, then check — the same order sqlite and per_agent_database already use. Two contract tests cover padded and blank ids. database and redis still store ids as-is, so those cases are recorded as divergences.
Fixes #6887
Testing:
pytest tests/unittests/sessions/test_session_service.py— 258 passed, 6 xfailed.