fix(plugins): allow complete LoggingPlugin output - #7079
Open
Manitchahar wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Expose the existing content and argument limits as keyword-only options. Preserve current defaults and accept None to disable truncation. Fixes google#6056
Manitchahar
force-pushed
the
fix/logging-plugin-truncation
branch
from
September 9, 2026 23:40
f5c96a6 to
36f32ef
Compare
Manitchahar
marked this pull request as ready for review
September 9, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Closes #6056.
LoggingPlugincuts off message text and system instructions at 200 characters,and tool arguments/results at 300. A diagnostic at the end of a long tool result
is therefore missing from the console output.
Add two keyword-only constructor options,
max_content_length=200andmax_args_length=300. Existing defaults are unchanged;Nonedisablestruncation. The change only touches the existing plugin and its test file.
This is a draft pending feedback on the constructor options requested in the
issue discussion. No maintainer agreement on this API is assumed.
Testing Plan
unlimited output through the public callbacks.
Results:
3.13, and 3.14, using isolated environments.
failures are in
TestSafetyLifecycleHardeningin the BigQuery analyticsplugin. Re-running that class against unchanged upstream
d9b57bfreproducedthe same eight failures, with 91 passing tests.
/bin/bashon Windows; its underlying command,python scripts/check_new_py_files.py --new-dir ., passes when run directly.The optional addlicense executable was not installed; existing license headers
were preserved.
uv build --wheelsucceeds. The documentation example executes successfully.still running without a result. It is not reported as passing. The broad
mypy run also did not finish and is not reported as passing.
Manual End-to-End Evidence
A real
InMemoryRunneruses a local scriptedBaseLlmto call a diagnostictool, then emit a model response. This exercises actual runner/plugin dispatch
without credentials or a remote model. The same reproduction passes from the
built wheel in an isolated environment.
Checklist
Runner reproduction
Save as logging_repro.py and run with the built wheel installed.
Companion documentation: google/adk-docs#2215