refactor(hv): replace trait IoeventFd with struct Notifier - #494
Merged
Merged
Conversation
Replace the trait IoeventFd with a concrete type struct Notifier, as only KVM supports I/O event notifications via KVM_IOEVENTFD. This simplifies functions and types. The refactoring is also needed to support vfio-user VFIO_USER_DEVICE_GET_REGION_IO_FDS, as for vio-user devices, the eventfds are created by the device process and passed to the VMM via Unix domain sockets. Then we cannot have the IoeventFd constructor bound to the registry type. Assisted-by: Antigravity:Claude-Opus-5 Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Coverage Report for CI Build 34741906547Warning No base build found for commit Coverage: 37.328%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the trait IoeventFd with a concrete type struct Notifier, as only KVM supports I/O event notifications via KVM_IOEVENTFD. This simplifies functions and types.
The refactoring is also needed to support vfio-user VFIO_USER_DEVICE_GET_REGION_IO_FDS, as for vio-user devices, the eventfds are created by the device process and passed to the VMM via Unix domain sockets. Then we cannot have the IoeventFd constructor bound to the registry type.
Assisted-by: Antigravity:Claude-Opus-5