Set fuzzer author as reporter for bugs from external fuzzers#5312
Set fuzzer author as reporter for bugs from external fuzzers#5312jr2bg wants to merge 10 commits into
Conversation
dylanjew
left a comment
dylanjew
left a comment
There was a problem hiding this comment.
Great job overall!
A couple things:
-
Change the branch to merge this into
master -
Please run
python butler.py formatandpython butler.py lint -
Could you add a section to your description explaining the steps that you went through to test this? It would be great to include screenshots of this is in dev and then verifying the field in the Datastore. Let me know if you have any questions
-
Similarly, the backfill script component of this bug probably warrants another section in the PR description. It should cover the order of operations for rolling out this change and how you're going to get the primary owner data for the backfill. Again, lmk if I can help with this. The state of our blackbox fuzzers is not great, and there are many that we need to track down their status/owners.
71a3845 to
1c3affd
Compare
1c3affd to
e4b33cd
Compare
| # Intercept new_issue so we can capture the saved issue object. | ||
| original_new_issue = issue_tracker.new_issue | ||
|
|
||
| def mock_new_issue(): |
There was a problem hiding this comment.
I'd prefer to mock as little as possible and keep the mocks to the external calls, e.g. the _execute request in test_filed_issue_google_issue_tracker
|
|
||
| issue.reporter = user_email | ||
| if fuzzer and getattr(fuzzer, 'primary_owner', None): | ||
| issue.reporter = fuzzer.primary_owner |
There was a problem hiding this comment.
We sometimes use the reporter to determine whether clusterfuzz filed the bug. Is there another place where we are setting metadata of some kind, e.g. a label/hotlist that stays on the bug so that we can continue to track clusterfuzz filed bugs?
e4b33cd to
4eb3238
Compare
- issue_filer.py Get fuzzer from DataStore query, handles cases when no `primary_owner` is found, does not consider yet `external_contribution. - migrate_fuzzer_owners.py Removes the owner
4921ce2 to
5c0f78e
Compare
2 participants
Changes:
primary_ownerfield toFuzzermodel indata_types.py.edit-form.html.fuzzers.pyhandler to save theprimary_ownerfield.file_issueinissue_filer.pyto usefuzzer.primary_owneras the reporter if available.issue_filer_test.pyto verify the new behavior.Feature tests
Show “owner” textbox
Preconditions
devinstanceSteps
Evidence
Step 3
Show owner entry on Pantheon Audit Logs
Preconditions
Steps
new_fuzzer_with_owner_jabglibfuzzer_chrome_asanNoneNoneTruenew_fuzzer_with_owner_jabgEvidence
Step 6
Step 10
