[NDB PERMISSION_DENIED] Introduce FuzzerRunOutputData and utils#5376
Open
IvanBM18 wants to merge 2 commits into
Open
[NDB PERMISSION_DENIED] Introduce FuzzerRunOutputData and utils#5376IvanBM18 wants to merge 2 commits into
IvanBM18 wants to merge 2 commits into
Conversation
Split output_or_file_path into _output and _file_path in FuzzerRunOutputData. Introduce from_file_path and from_memory factory classmethods to replace the single parameter initialization.
This was referenced Jul 24, 2026
IvanBM18
marked this pull request as ready for review
July 24, 2026 22:04
IvanBM18
commented
Jul 24, 2026
| if self._file_path: | ||
| if not os.path.exists(self._file_path): | ||
| return None | ||
| output = utils.read_data_from_file_and_remove( |
Collaborator
Author
There was a problem hiding this comment.
Deletes the files because output files are meant to be temp files that allows us to more easily capture the fuzzer's log output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: b/532610906
Context
Overview
This First PR(Of 4) to tackle an instance of PERMISSION_DENIED issues when executing a BlackBox test case in a
uworkerbot.This PR creates 2 new classes that will help us handle the processing of a test case execution in the next prs
Changes
PR stack
Current -> PR #5376: Introduce FuzzerRunOutputData and utils (Base: master)
PR #5377: Refactor _to_fuzzer_run_output to use FuzzerRunOutputData (Base: PR 1)
PR #5388: refactor: Add utils.create_temp_file helper (Base: PR 2)
PR #5378: Defer Blackbox Fuzzer Log Uploads (Base: PR 3)
Please only approve I'll merge the PRs to handle any merge conflicts :D