Skip to content

Fix engine fuzzers blobstore downloads #5386

Merged
dylanjew merged 2 commits into
masterfrom
dylanj/revert-blob-key-check
Jul 23, 2026
Merged

Fix engine fuzzers blobstore downloads #5386
dylanjew merged 2 commits into
masterfrom
dylanj/revert-blob-key-check

Conversation

@dylanjew

@dylanjew dylanjew commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

#5380 fixed the issue where our queue was getting flooded with bad tasks but broke libfuzzer because engine fuzzers do not need a blobstore_key. Instead it skips the function that was causing an error for the misconfigured fuzzers

I queried the Datastore and confirmed that when builtin=True, the blobstore_key is null for the engine fuzzers: syzkaller, googlefuzztest, centipede, libfuzzer. Additionally, the invalid fuzzer with "Name/ID": "name=ochang_js_fuzzer_test" is also there, which was what caused the initial errors

This fixed the invalid FuzzerJob handling, but caused an issue with other libfuzzer fuzzers because libfuzzer has no blobstore key, but skips this look up that would fail because it has not blobstore key since builtin = False

if not fuzzer.builtin:
update_input.fuzzer_download_url = blobs.get_signed_download_url(
fuzzer.blobstore_key)

@dylanjew
dylanjew requested a review from a team as a code owner July 23, 2026 19:32
@dylanjew
dylanjew requested a review from vitaliset July 23, 2026 19:35
@dylanjew
dylanjew force-pushed the dylanj/revert-blob-key-check branch from a695a02 to d1ea952 Compare July 23, 2026 19:48
@dylanjew
dylanjew force-pushed the dylanj/revert-blob-key-check branch from d1ea952 to bb1a247 Compare July 23, 2026 19:49
@dylanjew dylanjew changed the title Revert "Gracefully handle invalid ghost fuzzer configurations (#5380)" Fix engine fuzzers blobstore downloads Jul 23, 2026
@dylanjew
dylanjew requested a review from g-ortuno July 23, 2026 19:53
@g-ortuno

Copy link
Copy Markdown
Collaborator

How hard would it be to add a test as a follow up? 👀

@dylanjew

Copy link
Copy Markdown
Collaborator Author

How hard would it be to add a test as a follow up? 👀

Good point. I'll add a test 😄

@dylanjew
dylanjew force-pushed the dylanj/revert-blob-key-check branch from 3d0b762 to cc0b219 Compare July 23, 2026 20:27
@dylanjew

Copy link
Copy Markdown
Collaborator Author

How hard would it be to add a test as a follow up? 👀

Good point. I'll add a test 😄

Done!

@g-ortuno

Copy link
Copy Markdown
Collaborator

lgtm still!

@dylanjew
dylanjew force-pushed the dylanj/revert-blob-key-check branch from cc0b219 to dd79305 Compare July 23, 2026 20:34
@dylanjew

Copy link
Copy Markdown
Collaborator Author

Fixed formatting

@dylanjew
dylanjew merged commit 1b7bd5c into master Jul 23, 2026
15 checks passed
@dylanjew
dylanjew deleted the dylanj/revert-blob-key-check branch July 23, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants