Fix engine fuzzers blobstore downloads #5386
Merged
Merged
Conversation
dylanjew
force-pushed
the
dylanj/revert-blob-key-check
branch
from
July 23, 2026 19:48
a695a02 to
d1ea952
Compare
This reverts commit ba2f3c8.
dylanjew
force-pushed
the
dylanj/revert-blob-key-check
branch
from
July 23, 2026 19:49
d1ea952 to
bb1a247
Compare
g-ortuno
approved these changes
Jul 23, 2026
Collaborator
|
How hard would it be to add a test as a follow up? 👀 |
Collaborator
Author
Good point. I'll add a test 😄 |
dylanjew
force-pushed
the
dylanj/revert-blob-key-check
branch
from
July 23, 2026 20:27
3d0b762 to
cc0b219
Compare
Collaborator
Author
Done! |
Collaborator
|
lgtm still! |
dylanjew
force-pushed
the
dylanj/revert-blob-key-check
branch
from
July 23, 2026 20:34
cc0b219 to
dd79305
Compare
Collaborator
Author
|
Fixed formatting |
vitaliset
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5380 fixed the issue where our queue was getting flooded with bad tasks but broke libfuzzer because engine fuzzers do not need a
blobstore_key. Instead it skips the function that was causing an error for the misconfigured fuzzersI queried the Datastore and confirmed that when builtin=True, the blobstore_key is null for the engine fuzzers:
syzkaller, googlefuzztest, centipede, libfuzzer. Additionally, the invalid fuzzer with"Name/ID": "name=ochang_js_fuzzer_test"is also there, which was what caused the initial errorsThis fixed the invalid FuzzerJob handling, but caused an issue with other libfuzzer fuzzers because libfuzzer has no blobstore key, but skips this look up that would fail because it has not blobstore key since
builtin = Falseclusterfuzz/src/clusterfuzz/_internal/bot/tasks/setup.py
Lines 606 to 608 in 05360c5