Introduce doc(hidden) derive(Project) - #3492
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
- Coverage 91.90% 91.82% -0.09%
==========================================
Files 20 20
Lines 6130 6150 +20
==========================================
+ Hits 5634 5647 +13
- Misses 496 503 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
August 18, 2026 20:27
35b52b5 to
ba8ac3a
Compare
joshlf
requested changes
Aug 19, 2026
joshlf
requested changes
Aug 19, 2026
jswrenn
commented
Aug 26, 2026
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
5 times, most recently
from
August 27, 2026 21:19
f14a0cc to
f2265d4
Compare
jswrenn
commented
Aug 27, 2026
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
2 times, most recently
from
August 28, 2026 14:19
df8080c to
d32515a
Compare
jswrenn
changed the title
derive(Project)doc(hidden) derive(Project)
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
2 times, most recently
from
August 28, 2026 15:31
3501462 to
19a6a1b
Compare
jswrenn
force-pushed
the
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
branch
from
August 28, 2026 15:31
644b98b to
a175cac
Compare
joshlf
requested changes
Aug 28, 2026
jswrenn
commented
Aug 28, 2026
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
September 9, 2026 15:29
19a6a1b to
0484aa3
Compare
joshlf
approved these changes
Sep 9, 2026
jswrenn
force-pushed
the
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
branch
2 times, most recently
from
September 9, 2026 20:42
b7230a3 to
5d9811e
Compare
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
September 9, 2026 21:16
0484aa3 to
2b3ab46
Compare
jswrenn
force-pushed
the
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
branch
from
September 9, 2026 21:16
5d9811e to
ea4e7c3
Compare
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
September 9, 2026 21:45
2b3ab46 to
3a44dbe
Compare
jswrenn
force-pushed
the
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
branch
from
September 9, 2026 21:45
ea4e7c3 to
1101194
Compare
Base automatically changed from
Gd2bc8560585e8f472223acf71b96e0f71b2d00c2
to
main
September 10, 2026 16:03
joshlf
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
September 10, 2026 16:10
3a44dbe to
5239e82
Compare
This factors out the `derive(TryFromBytes)` into `project.rs`, and exposes this machinery as a doc-hidden `derive(Project)`. The implementation of `is_bit_valid` on enums is now fully safe, and a soundness issue of mutable enum tag projection is resolved by permitting only immutable tag projection. gherrit-pr-id: Gcc56a15ce65387a017464947e8c2f25dc9e8c737
jswrenn
force-pushed
the
Gcc56a15ce65387a017464947e8c2f25dc9e8c737
branch
from
September 10, 2026 18:35
5239e82 to
b7a0e7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors out the
derive(TryFromBytes)intoproject.rs, andexposes this machinery as a doc-hidden
derive(Project). Theimplementation of
is_bit_validon enums is now fully safe, and asoundness issue of mutable enum tag projection is resolved by
permitting only immutable tag projection.
invariant::Validtoinvariant::Safe#3665doc(hidden)derive(Project)#3492Latest Update: v16 — Compare vs v15
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gcc56a15ce65387a017464947e8c2f25dc9e8c737 && git checkout -b pr-Gcc56a15ce65387a017464947e8c2f25dc9e8c737 FETCH_HEADCheckout
git fetch origin refs/heads/Gcc56a15ce65387a017464947e8c2f25dc9e8c737 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gcc56a15ce65387a017464947e8c2f25dc9e8c737 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.