test(storage): fix system tests after gaxios migration - #9133
Open
thiyaguk09 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several updates to the storage library, including adding compress: false to file request options, enriching GaxiosError with legacy ApiError properties in StorageTransport, and updating various system tests to improve robustness, compatibility, and error handling. The review feedback highlights a critical issue where a non-existent makeRequest method is called on StorageTransport in a KMS test, as well as potential TypeError risks when accessing nested properties of myBucket.metadata and err.errors without optional chaining.
thiyaguk09
marked this pull request as ready for review
August 12, 2026 08:29
thiyaguk09
force-pushed
the
storage-gaxios-migration
branch
4 times, most recently
from
August 19, 2026 06:09
00dcb72 to
644cae2
Compare
thiyaguk09
force-pushed
the
storage-gaxios-migration
branch
2 times, most recently
from
August 27, 2026 04:29
8edeb26 to
5421117
Compare
thiyaguk09
force-pushed
the
storage-gaxios-migration
branch
from
August 28, 2026 14:16
5421117 to
d8b93e8
Compare
thiyaguk09
force-pushed
the
test/storage-system-gaxios
branch
from
August 28, 2026 17:04
5368e93 to
2cf0b5a
Compare
thiyaguk09
force-pushed
the
test/storage-system-gaxios
branch
from
August 28, 2026 17:40
2cf0b5a to
8576398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕