Skip to content

test(storage): fix system tests after gaxios migration - #9133

Open
thiyaguk09 wants to merge 1 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:test/storage-system-gaxios
Open

test(storage): fix system tests after gaxios migration#9133
thiyaguk09 wants to merge 1 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:test/storage-system-gaxios

Conversation

@thiyaguk09

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates to the storage library, including adding compress: false to file request options, enriching GaxiosError with legacy ApiError properties in StorageTransport, and updating various system tests to improve robustness, compatibility, and error handling. The review feedback highlights a critical issue where a non-existent makeRequest method is called on StorageTransport in a KMS test, as well as potential TypeError risks when accessing nested properties of myBucket.metadata and err.errors without optional chaining.

Comment thread handwritten/storage/system-test/storage.ts
Comment thread handwritten/storage/system-test/storage.ts Outdated
Comment thread handwritten/storage/system-test/storage.ts Outdated
@thiyaguk09 thiyaguk09 changed the title refactor(storage): gaxios migration system test fix test(storage): fix system tests after gaxios migration Aug 12, 2026
@thiyaguk09
thiyaguk09 marked this pull request as ready for review August 12, 2026 08:29
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner August 12, 2026 08:29
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 4 times, most recently from 00dcb72 to 644cae2 Compare August 19, 2026 06:09
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 2 times, most recently from 8edeb26 to 5421117 Compare August 27, 2026 04:29
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch from 5421117 to d8b93e8 Compare August 28, 2026 14:16
@thiyaguk09
thiyaguk09 force-pushed the test/storage-system-gaxios branch from 5368e93 to 2cf0b5a Compare August 28, 2026 17:04
@thiyaguk09
thiyaguk09 force-pushed the test/storage-system-gaxios branch from 2cf0b5a to 8576398 Compare August 28, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant