Skip to content

fix(storage): optimize stream download throughput and eliminate write latency - #9158

Closed
thiyaguk09 wants to merge 0 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:fix/stream-download-latency
Closed

fix(storage): optimize stream download throughput and eliminate write latency#9158
thiyaguk09 wants to merge 0 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:fix/stream-download-latency

Conversation

@thiyaguk09

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PassThroughShim class in handwritten/storage/src/util.ts by changing the order of state updates and event emissions, calling super._write synchronously, implementing _writev for vectorized writes, and updating _final to delegate to the base class when available. The feedback points out a TypeScript compilation issue in the new _writev method where the chunks parameter is typed with chunk: never, which causes errors under strict compilation, and suggests changing it to any.

Comment thread handwritten/storage/src/util.ts Outdated
@thiyaguk09
thiyaguk09 marked this pull request as ready for review August 18, 2026 12:17
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner August 18, 2026 12:17
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 2 times, most recently from 644cae2 to 8edeb26 Compare August 21, 2026 10:39
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 2 times, most recently from 5421117 to d8b93e8 Compare August 28, 2026 14:16
@thiyaguk09
thiyaguk09 force-pushed the fix/stream-download-latency branch from efa6c1f to a79be47 Compare August 28, 2026 16:50
@thiyaguk09 thiyaguk09 closed this Aug 28, 2026
@thiyaguk09
thiyaguk09 force-pushed the fix/stream-download-latency branch from a79be47 to d8b93e8 Compare August 28, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant