fix(bigframes): parenthesize OR expressions for AND chaining in SQLGlot - #18113
Draft
sycai wants to merge 2 commits into
Draft
fix(bigframes): parenthesize OR expressions for AND chaining in SQLGlot#18113sycai wants to merge 2 commits into
sycai wants to merge 2 commits into
Conversation
sycai
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that OR expressions are correctly parenthesized when combined with AND operators in the SQLGlot compiler, and adds unit tests to verify the generated SQL. The reviewer pointed out that using copy=False when parenthesizing expressions can lead to AST corruption in SQLGlot due to parent pointer mutation, and recommended copying the expression instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.