feat(storage): add run_benchmark_tests.sh for automated time-based GC… - #18138
Draft
shradhakatyal wants to merge 4 commits into
Draft
feat(storage): add run_benchmark_tests.sh for automated time-based GC…#18138shradhakatyal wants to merge 4 commits into
shradhakatyal wants to merge 4 commits into
Conversation
…S read microbenchmarks
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an automated Google Cloud Storage read microbenchmark runner script (run_benchmark_tests.sh) designed for GitHub CI/CD and high-bandwidth GCE VMs. The review feedback identifies two critical areas for improvement: first, a race condition and a NameError in the Python pre-seeding block where concurrent processes attempt to write to the same payload file and reference an undefined variable; second, a style guide violation where the configuration loaded from config.yaml is not type-validated before indexing.
added 3 commits
August 18, 2026 12:54
…andwidth Tier-1 VM runner
… name in run_benchmark_tests.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_benchmark_tests.shunderpackages/google-cloud-storage/cloudbuild/to automate high-bandwidth GCS read microbenchmarks for large objects (10 GiBfile sizes).config.yamlto test multi-process worker pools (PROCESSES=48) across standard REST andBidiReadObjectDirectPath gRPC (zonalbuckets).--benchmark-jsonfor automated ingestion into Cloud Build CI