Skip to content

chore: bump MSRV to 1.90 - #6291

Merged
alvarowolfx merged 3 commits into
googleapis:mainfrom
alvarowolfx:chore-update-msrv-1.90
Aug 7, 2026
Merged

chore: bump MSRV to 1.90#6291
alvarowolfx merged 3 commits into
googleapis:mainfrom
alvarowolfx:chore-update-msrv-1.90

Conversation

@alvarowolfx

@alvarowolfx alvarowolfx commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

It is more than a year since 1.88 and 1.89 turns 1 year old next Friday. So jumping to 1.90 as MSRV.

There is still a extract_if() cleanup to do in PubSub, but will leave for a separated PR.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Minimum Supported Rust Version (MSRV) from 1.88 to 1.90 across the repository, including documentation, Cargo.toml, and CI configurations. It also introduces a dedicated Google Cloud Build configuration for MSRV testing. Feedback points out a potential issue in the Terraform trigger configuration where removing the rust_version attribute could lead to an empty string overriding the default MSRV in Cloud Build, potentially causing build failures. A suggestion is provided to filter out null values in the Terraform substitutions map.

Comment thread .gcb/builds/triggers/main.tf
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (0fe6840) to head (2b5dc01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6291      +/-   ##
==========================================
- Coverage   96.25%   96.25%   -0.01%     
==========================================
  Files         283      283              
  Lines       72936    72936              
==========================================
- Hits        70204    70203       -1     
- Misses       2732     2733       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Cargo.toml
keywords = ["gcp", "google-cloud", "google-cloud-rust", "sdk"]
categories = ["network-programming"]
rust-version = "1.88.0"
rust-version = "1.90.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trigger is still using the 1.88 docker image. You need to manually update the trigger first (using the old school method) and then send this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then update the trigger again to use the new msrv.yaml file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, make sense. I was afraid of pushing the terraform updates and breaking other PR CI checks in the meantime while this PR is not merged. Will sync with the team to do so.

@alvarowolfx
alvarowolfx marked this pull request as ready for review August 7, 2026 15:55
@alvarowolfx
alvarowolfx requested a review from a team as a code owner August 7, 2026 15:55
@alvarowolfx
alvarowolfx force-pushed the chore-update-msrv-1.90 branch from 3e57d88 to 2b5dc01 Compare August 7, 2026 18:09
@alvarowolfx
alvarowolfx merged commit c760f4c into googleapis:main Aug 7, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants