impl(bigquery): support default project_id on ClientBuilder - #6293
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring a default Google Cloud project ID on the BigQuery client using the builder pattern, which is then automatically applied to executed queries. The feedback identifies a compilation error in BigQuery::query where a &String is passed to a method expecting Into<String>, and suggests using .as_str() to resolve the trait bound issue.
haphungw
force-pushed
the
feat-bq-client-project-id
branch
2 times, most recently
from
August 5, 2026 21:34
502a514 to
86fb162
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
=======================================
Coverage 96.25% 96.26%
=======================================
Files 283 283
Lines 72936 72982 +46
=======================================
+ Hits 70203 70253 +50
+ Misses 2733 2729 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
feat-bq-client-project-id
branch
from
August 5, 2026 21:54
86fb162 to
d43440a
Compare
haphungw
marked this pull request as ready for review
August 5, 2026 21:54
suzmue
approved these changes
Aug 5, 2026
alvarowolfx
reviewed
Aug 6, 2026
alvarowolfx
approved these changes
Aug 6, 2026
alvarowolfx
requested changes
Aug 6, 2026
alvarowolfx
left a comment
Contributor
There was a problem hiding this comment.
I think we can add a example section on the new with_project_id method.
alvarowolfx
approved these changes
Aug 6, 2026
haphungw
enabled auto-merge (squash)
August 6, 2026 18:35
haphungw
force-pushed
the
feat-bq-client-project-id
branch
from
August 6, 2026 19:19
1c22312 to
eba0005
Compare
haphungw
disabled auto-merge
August 7, 2026 15:58
haphungw
force-pushed
the
feat-bq-client-project-id
branch
from
August 7, 2026 17:18
eba0005 to
69e486f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring a default GCP
project_idonClientBuilder, which is stored on theBigQueryclient and automatically used as the billing project when running queries or attaching to jobs.For #6198