fix(compute/v1): feature-gate add-ons - #6384
Conversation
The code only compiled if a service with LROs was enabled. The hand-crafted code to extend `Operation` should only be included if that type is defined. The generator now emits a helpful internal-only feature for that purpose.
There was a problem hiding this comment.
Code Review
This pull request introduces a new internal feature gate __enable-discovery-LRO in the generated google-cloud-compute-v1 crate. It updates Cargo.toml to associate this feature with various client features, and conditionally compiles LRO-related errors, operation implementations, and tests in errors.rs and operation.rs using #[cfg] attributes. There are no review comments to evaluate, and I have no additional feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6384 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 288 288
Lines 75394 75394
=======================================
+ Hits 72517 72521 +4
+ Misses 2877 2873 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Funny that you ask, I was working on them... |
The code only compiled if a service with LROs was enabled. The hand-crafted code to extend
Operationshould only be included if that type is defined. The generator now emits a helpful internal-only feature for that purpose.Fixes #6220