Skip to content

fix(compute/v1): feature-gate add-ons - #6384

Merged
coryan merged 5 commits into
googleapis:mainfrom
coryan:fix-compute-feature-thing
Aug 14, 2026
Merged

fix(compute/v1): feature-gate add-ons#6384
coryan merged 5 commits into
googleapis:mainfrom
coryan:fix-compute-feature-thing

Conversation

@coryan

@coryan coryan commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The code only compiled if a service with LROs was enabled. The hand-crafted code to extend Operation should only be included if that type is defined. The generator now emits a helpful internal-only feature for that purpose.

Fixes #6220

The code only compiled if a service with LROs was enabled. The hand-crafted
code to extend `Operation` should only be included if that type is defined. The
generator now emits a helpful internal-only feature for that purpose.
@product-auto-label product-auto-label Bot added the api: compute Issues related to the Compute Engine API. label Aug 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new internal feature gate __enable-discovery-LRO in the generated google-cloud-compute-v1 crate. It updates Cargo.toml to associate this feature with various client features, and conditionally compiles LRO-related errors, operation implementations, and tests in errors.rs and operation.rs using #[cfg] attributes. There are no review comments to evaluate, and I have no additional feedback to provide.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.18%. Comparing base (207064f) to head (cb2a5de).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6384   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         288      288           
  Lines       75394    75394           
=======================================
+ Hits        72517    72521    +4     
+ Misses       2877     2873    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on CI updates?

@coryan

coryan commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Thoughts on CI updates?

Funny that you ask, I was working on them...

@coryan
coryan marked this pull request as ready for review August 14, 2026 01:08
@coryan
coryan requested review from a team as code owners August 14, 2026 01:08
@coryan
coryan enabled auto-merge (squash) August 14, 2026 01:08
@coryan
coryan merged commit 0a35efd into googleapis:main Aug 14, 2026
41 checks passed
@coryan
coryan deleted the fix-compute-feature-thing branch August 14, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute does not build with --no-default-features

2 participants