test: add pytest coverage for rs2gp pure helpers (measures, events, timing) - #11
Merged
Conversation
…iming) rs2gp.py imports the host lib module 'song' at top level; a conftest stub supplies arrangement_string_count so the module - and the deterministic helpers under test - can be imported standalone. requirements.txt pins PyGuitarPro since guitarpro. Duration objects are exercised directly by the sixteenth-note decomposition tests (real dependency, no need to stub it). Covers measure parsing (grouping, BPM estimation, end-time extrapolation), note/chord event merging + sort + high-density chord skipping, used-string-index collection, sixteenth-note quantization, and duration decompose/re-measure round-trips. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds a PyGuitarPro dependency to requirements.txt, updates tests/conftest.py to configure sys.path and stub a song module, and introduces tests/test_rs2gp_helpers.py containing unit tests for several internal helper functions in rs2gp.py. Changesrs2gp Test Enablement
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twenty-seventh repo from the org test-coverage audit. rs2gp.py (the RS-to-GuitarPro-5 converter) imports two dependencies at module top level: guitarpro (PyGuitarPro, a real pip package - pinned in the new requirements.txt) and song.arrangement_string_count (a host-provided lib module this plugin repo does not ship). A conftest stub supplies just that one symbol so the module imports standalone in CI, without touching the GP5 binary-writing path itself.
14 pytest tests:
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Tests