Skip to content

feat: add chat member tag field#457

Merged
ernado merged 1 commit into
gotd:mainfrom
fluffur:feat/add-chat-member-tag-field
Jun 17, 2026
Merged

feat: add chat member tag field#457
ernado merged 1 commit into
gotd:mainfrom
fluffur:feat/add-chat-member-tag-field

Conversation

@fluffur

@fluffur fluffur commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@fluffur fluffur changed the title add chat member tag field feat: add chat member tag field Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.78%. Comparing base (0b63b4e) to head (b85949f).

Files with missing lines Patch % Lines
convert_member.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   78.78%   78.78%           
=======================================
  Files         118      118           
  Lines        8315     8316    +1     
=======================================
+ Hits         6551     6552    +1     
  Misses       1237     1237           
  Partials      527      527           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ernado

ernado commented Jun 17, 2026

Copy link
Copy Markdown
Member

Thanks for the PR! This repo enforces Conventional Commits via commitlint in CI, so the individual commit messages need a type prefix. The current two commits are:

add chat member tag field
indent fixes

Neither has a Conventional Commits prefix (feat:, fix:, etc.). The simplest fix is to squash both into one feat: commit. From your branch (feat/add-chat-member-tag-field):

# reset to base, keeping your changes staged
git reset --soft $(git merge-base origin/main HEAD)

# re-commit as a single conventional commit
git commit -m "feat: add chat member tag field"

# update the PR
git push --force-with-lease

If you would rather keep two commits, just make sure each message is prefixed, e.g. feat: add chat member tag field and style: fix indentation.

@fluffur fluffur force-pushed the feat/add-chat-member-tag-field branch from d1ff62e to b85949f Compare June 17, 2026 09:46
@ernado ernado merged commit 3466ee3 into gotd:main Jun 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants