Redirect forms-runner to 'Edit question routes' page when multiple branches enabled - #3129
Merged
lfdebrux merged 1 commit intoSep 18, 2026
Conversation
…anches enabled Currently when previewing a draft form with a route that goes backwards, forms-runner shows an error page instead of trapping the user in an infinite loop. The error page has a link to forms-admin, using the `redirect_from_forms_runner#routes` URL [[1]]. When the multiple branches feature is enabled for a form, we want the link from forms-runner to edit the routes for a question to go to the new 'Edit question routes' page, rather than the old routes journey. [1]: https://github.com/govuk-forms/forms-runner/blob/cfc34640ad85d2be9f7f21f055a3fd8212c47886/app/controllers/forms/step_controller.rb#L202).
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3129.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
SamJamCul
approved these changes
Sep 18, 2026
lfdebrux
deleted the
ldeb-update-redirect-from-forms-runner-for-multiple-branches
branch
September 18, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/ufMggbI2/3272-make-forms-runner-backwards-route-error-page-work-with-multiple-branches-post-release
Currently when previewing a draft form with a route that goes backwards, forms-runner shows an error page instead of trapping the user in an infinite loop. The error page has a link to forms-admin, using the
redirect_from_forms_runner#routesURL [[1]].When the multiple branches feature is enabled for a form, we want the link from forms-runner to edit the routes for a question to go to the new 'Edit question routes' page, rather than the old routes journey as it does currently.
This PR updates the controller action to choose the correct page based on the
multiple_branchesfeature flag.[1]: https://github.com/govuk-forms/forms-runner/blob/cfc34640ad85d2be9f7f21f055a3fd8212c47886/app/controllers/forms/step_controller.rb#L202).
Things to consider when reviewing