Skip to content

Use feature service for multiple branches feature - #3131

Merged
lfdebrux merged 2 commits into
mainfrom
ldeb-fix-multiple-branches-feature-flag
Sep 18, 2026
Merged

lfdebrux merged 2 commits into
mainfrom
ldeb-fix-multiple-branches-feature-flag

Conversation

@lfdebrux

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/0lGbh5He/3251-launch-multiple-branches

We can't release the feature if we don't use the feature service.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

SamJamCul
SamJamCul previously approved these changes Sep 18, 2026
@lfdebrux
lfdebrux enabled auto-merge September 18, 2026 09:52
@lfdebrux
lfdebrux force-pushed the ldeb-fix-multiple-branches-feature-flag branch from 217770b to 9895cba Compare September 18, 2026 10:01
We can't release the feature if we don't use the feature service.
@lfdebrux
lfdebrux force-pushed the ldeb-fix-multiple-branches-feature-flag branch from 9895cba to d64bafa Compare September 18, 2026 10:15
SamJamCul
SamJamCul previously approved these changes Sep 18, 2026
@lfdebrux
lfdebrux force-pushed the ldeb-fix-multiple-branches-feature-flag branch from d64bafa to 6c3ecd5 Compare September 18, 2026 10:23
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3131.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@lfdebrux
lfdebrux added this pull request to the merge queue Sep 18, 2026
Merged via the queue into main with commit 6d5d479 Sep 18, 2026
3 checks passed
@lfdebrux
lfdebrux deleted the ldeb-fix-multiple-branches-feature-flag branch September 18, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants