Add css border to live pages route summary - #3132
Draft
DavidBiddle wants to merge 2 commits into
Draft
DavidBiddle wants to merge 2 commits into
DavidBiddle wants to merge 2 commits into
Conversation
When we built this component, we added CSS to remove the border on the last item in a summary list. This is now handled in the Design System component, so our custom style is redundant.
Usually the summary list will be the last item in a summary card, so it makes sense to remove the border on the last row. However, in our case we sometimes add additional content to the summary card - for example, on the live pages view we now add exit page content to the summary card after the summary list. This commit updates our custom summary card CSS so that it will add a border and spacing to the bottom of any summary list within a card that has additional content after it. This should make the component easier to understand visually.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3132.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing