Ensure end to end tests will continue passing when multiple branches feature is released - #333
Merged
Merged
Conversation
When the multiple branches feature is released generally in forms-admin, the way to add or edit routes for a form will change. This commit updates the code for creating a test form in the end to end specs to work with either the new "Edit question routes" page to add routes or the old journey when the multiple branches feature is not enabled, depending on what buttons are present on the "Add and edit your questions" page.
lfdebrux
force-pushed
the
ldeb-multiple-branches
branch
from
September 16, 2026 12:55
7e6ba4b to
1a52ff7
Compare
SamJamCul
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/TnXaNTsk/3245-fix-existing-end-to-end-tests-that-use-routing
When the multiple branches feature is released generally in forms-admin, the way to add or edit routes for a form will change.
This PR updates the code for creating a test form in the end to end specs to work with either the new "Edit question routes" page to add routes or the old journey when the multiple branches feature is not enabled, depending on what buttons are present on the "Add and edit your questions" page.
I tested this locally by enabling the
multiple_branchesfeature flag for the end to end tests group.Things to consider when reviewing