Skip to content

Name queue worker job traces with job class - #2331

Open
whi-tw wants to merge 1 commit into
mainfrom
whi-tw/3269-trace-queue-worker
Open

whi-tw wants to merge 1 commit into
mainfrom
whi-tw/3269-trace-queue-worker

Conversation

@whi-tw

@whi-tw whi-tw commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/KnaPaYVl/3269-tracing-for-cron-jobs-queue-worker

This means that in the trace map, it's easier to understand
where the traces are being emitted from. As there's no user interaction
that triggers these jobs, there's no 'interaction wrapper' around
the traces.

This is related to govuk-forms/forms-deploy#2266

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

This means that in the trace map, it's easier to understand
where the traces are being emitted from. As there's no user interaction
that triggers these jobs, there's no 'interaction wrapper' around
the traces.
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant