Skip to content

wip: Store form version on submissions - #2332

Draft
alice-carr wants to merge 1 commit into
mainfrom
add-form-version-to-submissions
Draft

alice-carr wants to merge 1 commit into
mainfrom
add-form-version-to-submissions

Conversation

@alice-carr

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

this commit stores the version of the form document returned by forms-admin when we save a submission to the database. this includes adding a new column to the submissions database to store this

Trello card: https://trello.com/c/fQlDXVMx/3249-store-form-version-on-submissions-and-retrieve-the-form-using-the-v3-api

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@alice-carr
alice-carr force-pushed the add-form-version-to-submissions branch from 626715e to 02d1f0f Compare September 8, 2026 14:10
this commit stores the version of the form document returned by forms-admin when we save a submission to the database.
this includes adding a new column to the submissions database to store this
@alice-carr
alice-carr force-pushed the add-form-version-to-submissions branch from 02d1f0f to 197443c Compare September 14, 2026 11:56
@github-actions

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant