Remove V2 namespacing from shared resources and factories - #2350
Merged
Merged
Conversation
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
We want to remove a lot of the references to `v2` as these resources and factories will be used in v3 requests as well.
This resource is shared between the v2 and v3 APIs, so this namespace can be removed.
This resource is shared between the v2 and v3 APIs, so this namespace can be removed.
This resource is shared between the v2 and v3 APIs, so this namespace can be removed.
This resource is shared between the v2 and v3 APIs, so this namespace can be removed.
DavidBiddle
force-pushed
the
remove-v2-from-names
branch
from
September 18, 2026 14:28
b970ea4 to
fabb9c4
Compare
DavidBiddle
marked this pull request as ready for review
September 18, 2026 14:33
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
There are some resources in the V2 API that we're also using in the new V3 API. It could be confusing to keep the existing namespacing, and it would be duplicative to create new versions for the new API when they're not changing.
This PR:
V2::namespacing from the resources that are shared across both API versionsv2_factories.Things to consider when reviewing