Add a separate route for submitting file upload answers - #2352
Draft
stephencdaly wants to merge 1 commit into
Draft
stephencdaly wants to merge 1 commit into
stephencdaly wants to merge 1 commit into
Conversation
We need to be able to exempy file upload requests from particular WAF rules: - the file size rule so requests can include files >8KB in size - the XSS rule, so that files that contain XML, such as PDFs are not blocked. So that we don't need to allow these rules for submitting all answer types, make it so that file upload requests are submitted to a dedicated route. For now, this still allows file uploads to be submitted to the standard save question route so we don't cause issues for users currently filling out forms, but this will be changed in a separate deployment. Co-Authored-By: Claude
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge until the WAF rules have been updated to allow large request bodies for the new file upload route (as well as the save question route)
What problem does this pull request solve?
We need to be able to exempy file upload requests from particular WAF rules:
So that we don't need to allow these rules for submitting all answer types, make it so that file upload requests are submitted to a dedicated route.
For now, this still allows file uploads to be submitted to the standard save question route so we don't cause issues for users currently filling out forms, but this will be changed in a separate deployment.
Things to consider when reviewing